Fix std::bad_alloc error by properly initializing Array memory#85
Fix std::bad_alloc error by properly initializing Array memory#85keceli wants to merge 12 commits into
Conversation
- Root cause: Array<T> constructor allocated memory but didn't initialize it - For primitive types like int_t, this caused garbage values in memory - LAPACK workspace queries read these garbage values as workspace sizes - Result: unreasonable workspace sizes (e.g., 127 trillion) causing std::bad_alloc Fix: - Initialize new memory to zero using std::fill() when no existing data to copy - Ensures all Array<T> objects are properly initialized - Prevents similar memory corruption issues throughout codebase Resolves: std::bad_alloc errors in LAPACK eigenvalue calculations
|
@avcopan did you have a chance to test this one? |
|
I did. I didn't time it, but seemed like it runs much slower, so I'm hesitant to merge. |
|
I don't know why would these changes slow down the code. Did you check with |
|
@keceli I can't do an apples to apples comparison because I can't compile the code without this, but comparing Yuri's static executable to my compiled executable there is a significant difference... Yuri's executable: My executable, build with |
|
Here are the files if you want to try it out yourself. You can just rename the Pixi configs to (Note: I had to add the |
|
The slowdown may well be caused by something other than this change, but I am wary to merge it without proper testing and without Yuri's approval. |
|
Thanks @avcopan. I reproduced the slowdown. It is due to GSL CBLAS wrapper (libgslcblas) which is not optimized. I observe the same slowdown when it links to |
- Removed test_integer_interface executable from CMakeLists.txt - Deleted test_mkl_ilp64.cpp source file - Cleaned up build configuration
- Remove malformed LDFLAGS and LIBS from GSL_CONFIGURE_OPTIONS - Use CMAKE_COMMAND -E env to properly set environment variables - Fix LDFLAGS to point to correct library directory - This should resolve the CI build failure
- Properly quote environment variables in CMAKE_COMMAND -E env - This should resolve the syntax warning and command parsing issues - Fixes CI build failure with GSL configure step
- Use GSL's internal CBLAS instead of trying to link external BLAS - Remove complex environment variable setup that was causing build failures - This should make the CI build more reliable and avoid linking issues - GSL will use its internal CBLAS implementation which is sufficient for basic operations
|
@avcopan could you try again? I am now getting the same timing with the pixi installed version and this one. |
…ummary - Set CMAKE_BUILD_TYPE to Release by default if not specified - Add comprehensive build configuration summary at configure time - Display build type, C++ standard, and all project options - Makes it easier to verify build settings during configuration
2 participants
Fix:
Resolves: std::bad_alloc errors in LAPACK eigenvalue calculations