Repository navigation
Support content-type extensions with and without a leading dot - #13
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates SBOM content-type detection to recognize both .json and json extensions, preventing duplicate VSIX entries.
Changes:
- Normalize leading dots before matching JSON extensions.
- Preserve existing NuGet behavior.
| File | Description |
|---|---|
nuke/SbomGenerator.cs |
Recognizes JSON content types with or without a leading dot. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TryRegisterJsonContentTypeonly matchedExtension="json". vsce writes content types with a leading dot (.json), so embedding the SBOM into a.vsixadded a secondjsondefault to[Content_Types].xml. The VS Code Marketplace rejects packages with that duplicate entry.The check now ignores a leading dot, so an existing
.json(vsce) orjson(NuGet) entry is recognised and nothing is added.🤖 Generated with Claude Code