chore: pin ruff to 0.15.22 - #24
Merged
Merged
Conversation
CI ran `pip install ruff` (unpinned — whatever released most recently) while pre-commit pinned v0.15.11. Two gates, two linters, and nothing forcing them to agree. ruff 0.16.0 expanded its DEFAULT rule set: EXE, I and UP now fire where 0.15.x reported nothing. This tree has 22 such findings, so the very next CI run would have gone red without a single line of code changing. The last green run here was 2026-07-16, before 0.16.0 shipped on 2026-07-23 — the badge is stale, not passing. Pinned to 0.15.22, the NEWEST release this tree actually passes, verified with CI's exact commands rather than assumed. Deliberately not 0.16.0: adopting its new rules means real changes and belongs in its own reviewable PR, not smuggled into a pinning commit. pre-commit bumped to match. Verified it passes and touches no source file, which matters because the hook runs `ruff --fix` and `ruff-format` — both of which MODIFY files. This repo's own conventions already say "Pin all Actions by SHA with version comment"; ruff was the sole floating input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI ran
pip install ruff— unpinned, whatever released most recently — while pre-commit pinnedv0.15.11. Two gates, two linters, nothing forcing them to agree.This one was about to break
ruff 0.16.0 expanded its default rule set:
EXE,IandUPnow fire where 0.15.x reported nothing. This tree has 22 such findings, so the next CI run would have gone red without a single line of code changing.The last green run here was 2026-07-16; ruff 0.16.0 shipped 2026-07-23. The badge is stale, not passing.
Pinned to 0.15.22, not 0.16.0
0.15.22 is the newest release this tree actually passes — verified with CI's exact commands, not assumed.
Deliberately not 0.16.0: adopting its new rules means real code changes, and that belongs in its own reviewable PR rather than smuggled into a pinning commit.
pre-commit bumped to match. Verified it passes and touches no source file — which matters, because the hook runs
ruff --fixandruff-format, and both modify files.This repo's own conventions already say "Pin all Actions by SHA with version comment" — ruff was the sole floating input.