Repository navigation
test(docs): match the webapp tutorial's e2e suites to its app and wallet - #25785
Open
alejoamiras wants to merge 1 commit into
Open
alejoamiras wants to merge 1 commit into
alejoamiras wants to merge 1 commit into
Conversation
Both e2e suites tested UI that the tutorial has never shipped, so test-webapp-e2e passed 1/7 in both lines: - The embedded-wallet tests waited for the single-player WalletConnect form, but the local network renders the two-player split screen. They now cover that screen: player 2 can connect only after player 1, and player 1 connects to a running local network. - The extension tests expected an "Aztec Test Wallet" that approves discovery on its own. The tutorial wallet is "Aztec Tutorial Wallet" and holds discovery, the session and the capability request until the user approves them in its popup. The tests now send the popup's approval messages from the extension's offscreen page. They confirm the session whose emojis match the app's, and assert that the app's capability request then reaches the wallet.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webapp tutorial's browser tests had never matched the app: they waited for a WalletConnect screen the local network doesn't show, and for an auto-approving test wallet the tutorial doesn't ship. They now cover the two-player screen and approve the tutorial's own wallet through its popup, and pass 7/7 in both docs lines. Only the tests change.