[App Service] az webapp create: Add --site-scoped-certs parameter to support enabling or disabling site-scoped certificates#33306
Open
danielw5 wants to merge 5 commits into
Open
[App Service] az webapp create: Add --site-scoped-certs parameter to support enabling or disabling site-scoped certificates#33306danielw5 wants to merge 5 commits into
az webapp create: Add --site-scoped-certs parameter to support enabling or disabling site-scoped certificates#33306danielw5 wants to merge 5 commits into
Conversation
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the App Service command module for configuring the App Service SiteScopedCertificatesEnabled setting via Azure CLI, exposed on az webapp create and az webapp update.
Changes:
- Adds
--site-scoped-certificates-enabledparameter towebapp createandwebapp updateargument contexts. - Wires the parameter through
create_webapp(Site payload construction) andupdate_webapp(generic update mutation) to setsite_scoped_certificates_enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/appservice/custom.py |
Adds the new function parameter and maps it into the Site model for create/update flows. |
src/azure-cli/azure/cli/command_modules/appservice/_params.py |
Exposes --site-scoped-certificates-enabled on webapp create and webapp update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+260
to
+264
| https_only=https_only, virtual_network_subnet_id=subnet_resource_id, | ||
| public_network_access=public_network_access, outbound_vnet_routing=outbound_vnet_routing, | ||
| auto_generated_domain_name_label_scope=auto_generated_domain_name_label_scope, | ||
| end_to_end_encryption_enabled=end_to_end_encryption_enabled) | ||
| end_to_end_encryption_enabled=end_to_end_encryption_enabled, | ||
| site_scoped_certificates_enabled=site_scoped_certificates_enabled) |
There was a problem hiding this comment.
site_scoped_certificates_enabled (and currently end_to_end_encryption_enabled) come from get_three_state_flag(return_label=True), which returns the strings 'true'/'false'. Passing these strings directly into the Site(...) model will serialize as JSON strings (or potentially raise if the model validates types) rather than booleans. Convert these values to booleans (e.g., val == 'true') before constructing Site, keeping None as-is, to match the behavior already used in update_webapp.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
changed the title
az webapp create: Add --site-scoped-certs parameter to support enabling or disabling site-scoped certificates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.