{NetAppFiles} Fix test_volume_create_with_cmk recording: align identity api-version to 2025-05-31-preview#33478
Merged
necusjz merged 1 commit intoJun 2, 2026
Conversation
…ities recording api-version to 2025-05-31-preview
YangAn-microsoft
requested review from
DanielMicrosoft,
bebound,
jiasli,
necusjz and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
requested review from
kairu-ms,
wangzelin007 and
zhoxing-ms
microsoft-github-policy-service
Bot
added
Managed Identity
microsoft-github-policy-service
Bot
added
NetAppFiles
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a broken NetAppFiles scenario test playback by updating the recorded az identity create request URI in a VCR cassette to match the current az identity API version (2025-05-31-preview), avoiding cassette mismatches during playback on dev.
Changes:
- Updated the
Microsoft.ManagedIdentity/userAssignedIdentitiesPUT requestapi-versionintest_volume_create_with_cmk.yamlfrom2024-11-30to2025-05-31-preview.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
isra-fel
approved these changes
Jun 2, 2026
Member
|
QQ: Why PR validation didn't fail for https://github.com/Azure/azure-cli/pull/32214/changes |
Collaborator
necusjz
approved these changes
Jun 2, 2026
Member
probably its ci completely executed before the related check-in. |
Member
|
It is not a good practice to manually edit the recording file. It's better to rerun the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a broken playback test on dev caused by a semantic merge conflict between two PRs that merged the same day:
az identity create/update: Add new--resource-restrictionparameter to support identity assignment restrictions #32214 ([Identity] az identity create/update) bumpedaz identitytoapi-version=2025-05-31-previewand bulk-updated the request URIs in existing recordings.test_volume_create_with_cmk.yamlwhose identity-create request was recorded at the oldapi-version=2024-11-30.Because both merged concurrently, #32214's bulk find-and-replace never touched the new netappfiles cassette, so on
devthe live request (2025-05-31-preview) no longer matches the recorded request (2024-11-30), producing:vcr.errors.CannotOverwriteExistingCassetteExceptionThis PR aligns the recorded
userAssignedIdentitiesPUT request URI to2025-05-31-preview, matching the currentaz identityapi-version (same mechanical change #32214 applied to all other affected cassettes).Testing