fix: pass ContainerEngine to dotnet publish when Podman is used#8527
Open
vhvb1989 wants to merge 1 commit into
Open
fix: pass ContainerEngine to dotnet publish when Podman is used#8527vhvb1989 wants to merge 1 commit into
vhvb1989 wants to merge 1 commit into
Conversation
When users have Podman instead of Docker, `dotnet publish /t:PublishContainer` defaults to Docker and fails silently, producing empty stdout. This causes azd to error with "empty dotnet configuration output". This change threads the detected container engine from docker.Cli through to the dotnet publish commands via a new `containerEngine` parameter. When the engine is "podman", azd appends `-p:ContainerEngine=podman` to the MSBuild command, telling the .NET SDK to use Podman for container operations. Changes: - Export `ContainerEngine()` getter on `docker.Cli` - Add `ContainerEngine()` delegate on `ContainerHelper` - Add `containerEngine` parameter to `BuildContainerLocal` and `PublishContainer` - Add `appendContainerEngine` helper in dotnet package - Add tests for podman/docker/empty engine scenarios Fixes #8525 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Aspire container publish failures when users are running Podman instead of Docker by threading the detected container runtime into dotnet publish /t:PublishContainer. It ensures the .NET SDK is explicitly told which engine to use (via -p:ContainerEngine=podman) so the generated container configuration output is produced correctly and azd doesn’t hit the “empty dotnet configuration output” error.
Changes:
- Expose the detected container engine from
docker.Cliand surface it viaproject.ContainerHelper. - Extend
dotnet.Clicontainer publish/build helpers to acceptcontainerEngineand append-p:ContainerEngine=<engine>when appropriate. - Add unit tests covering podman/docker/empty engine behavior for both local-build and publish paths.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cli/azd/pkg/tools/dotnet/dotnet.go | Adds containerEngine parameter plumbing and appends -p:ContainerEngine=... for non-docker engines. |
| cli/azd/pkg/tools/dotnet/dotnet_commands_test.go | Adds test coverage ensuring ContainerEngine property is appended (podman) or omitted (docker/empty). |
| cli/azd/pkg/tools/docker/docker.go | Exposes ContainerEngine() getter (wrapping existing engine-selection logic). |
| cli/azd/pkg/project/service_target_dotnet_containerapp.go | Passes detected container engine through dotnet container build/publish call sites. |
| cli/azd/pkg/project/container_helper.go | Adds ContainerEngine() delegate and threads engine into runDotnetPublish. |
vhvb1989
requested review from
JeffreyCA,
RickWinter,
hemarina and
tg-msft
as code owners
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When users have Podman instead of Docker,
dotnet publish /t:PublishContainerdefaults to Docker and fails silently — producing empty stdout. This causes azd to error with:Upstream issue: microsoft/aspire#17593
Root Cause
azd detects the container runtime (Docker vs Podman) in
docker.Cli.CheckInstalled(), but this information was never passed todotnet publish. The .NET SDK supports a-p:ContainerEngine=podmanMSBuild property, but azd was not setting it.Fix
Thread the detected container engine from
docker.Clithrough to the dotnet publish commands:docker.Cli: ExportContainerEngine()getter (wraps existing privategetContainerEngine())ContainerHelper: AddContainerEngine()delegate methoddotnet.Cli: AddcontainerEngineparameter toBuildContainerLocalandPublishContainer; append-p:ContainerEngine=podmanwhen engine is not DockerdotnetContainerAppTarget,ContainerHelper)Testing
-p:ContainerEngine=podmanis appendedPublishContainer(remote push) pathFixes #8525