Skip to content

Fix Relationships C# model name - #46575

Merged
Wei Hu (live1206) merged 5 commits into
Azure:mainfrom
meghanagupta95:fix/relationships-csharp-model-name
Sep 30, 2026
Merged

Wei Hu (live1206) merged 5 commits into
Azure:mainfrom
meghanagupta95:fix/relationships-csharp-model-name

Conversation

@meghanagupta95

Copy link
Copy Markdown
Member

SDK configuration pull request

Purpose of this PR

  • Make changes to the SDK configuration only when there are no modifications to the API specification, eliminating the need for an ARM or Stewardship Board API review.

Due diligence checklist

  • I confirm this PR is modifying only SDK configurations, and not API related specifications.
  • I have reviewed and used the ARM tspconfig template.

Summary

Maps the intentional TypeSpec ServiceGroupMemberRelationshipPropertiesV2 model to the existing clean C# SDK name ServiceGroupMemberRelationshipProperties. The legacy shape receives the distinct C# name ServiceGroupMemberRelationshipPropertiesLegacy.

This addresses the compile failures in Azure/azure-sdk-for-net#63238 without exposing the TypeSpec V2 suffix in the stable .NET SDK.

Release plan: 35597

Validation

  • Azure SDK TypeSpec validation succeeded for specification/relationships/resource-manager/Microsoft.Relationships/Relationships.
  • client.tsp has no editor diagnostics.

@meghanagupta95 Meghana Gupta (meghanagupta95) added the Created By Copilot This indicates that PR was created by GitHub copilot agent label Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added ARMReview resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 22, 2026
@github-actions github-actions Bot added ARMAutoSignedOff-Trivial ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review ARMAutoSignedOff-Test and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 22, 2026
@meghanagupta95 Meghana Gupta (meghanagupta95) added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required PublishToCustomers Acknowledgement the changes will be published to Azure customers. and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review ARMAutoSignedOff-Trivial ARMAutoSignedOff-Test labels Sep 22, 2026
@github-actions github-actions Bot added ARMAutoSignedOff-Trivial ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review ARMAutoSignedOff-Test and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/relationships/armrelationships
Python azure-mgmt-relationships
C# Azure.ResourceManager.Relationships
JavaScript @azure/arm-relationships

Comment generated by After APIView workflow run.

@github-actions

Copy link
Copy Markdown

ARM API Review Summary

Reviewed PR #46575 at head SHA 0025cf3f4a12226477d4b41b26bb82329dfdbefb | Triggered by: pull_request_target

Approval labels observed: none.

Category Count
🔴 Blocking 0
🟠 Warning 0
🔵 Suggestion 0

No issues found. The fast-path review covered the single TypeSpec client customization; the final critic confirmed it changes only generated C# SDK names and not the ARM/API contract.

posted-by: arm-api-reviewer-agent | rule: summary | category: summary | severity: suggestion | classification: existing | critic: pass | head-sha: 0025cf3

🔍 ARM API review by ARM API Review: Automated Workflow

@live1206
Wei Hu (live1206) merged commit 6a1a4dd into Azure:main Sep 30, 2026
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMAutoSignedOff-Test ARMAutoSignedOff-Trivial ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Created By Copilot This indicates that PR was created by GitHub copilot agent PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants