[code sync] Merge code from sonic-net/sonic-swss:202605 to 202606 - #307
Merged
Merged
Conversation
mssonicbld
commented
Sep 23, 2026
mssonicbld
commented
Collaborator
Do not drop notifications when its coming from a different asic. Fixes: sonic-net/sonic-buildimage#27283 <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** Make changes to compare both hostnames and asic names for multi-asic devices. Improve unit test to check for this case. **Why I did it** Currently we only match the hostname and drop the notification if the hostname is equal to the hostname of the port. This also drops messages coming from a neigh asic that shares the same hostname. **How I verified it** Ran the new test here to verify it passes with this fix: sonic-net/sonic-mgmt#24826 This was verified in 202605 by patching this fix and the sonic-mgmt enhancement that tests for this exact regression: sonic-net/sonic-mgmt#24826 **Tested branches** - [x] 202605 - [x] 202511 Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
Author
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.