Add option for piston downward speed - #4779
Open
Endernice61 wants to merge 4 commits into
Open
Conversation
Signed-off-by: Endernice61 <98556236+Endernice61@users.noreply.github.com>
Signed-off-by: Endernice61 <98556236+Endernice61@users.noreply.github.com>
Signed-off-by: Endernice61 <98556236+Endernice61@users.noreply.github.com>
Signed-off-by: Endernice61 <98556236+Endernice61@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the speed of the segment to move to the appropriate speed
Rename and redescribe original widget to indicate that it is the speed that the piston moves upward
Added new widget for downward piston speed
Gets downward piston speed in
vbsp_configand passes it toPistonPlatformFixed frame perfect I/O break where the platform doesn't turn around:
desired_directionin_upand_dnin segment codedesired_directionis not set in segment code, callsverifyDirectionwith the original direction and records the time inverify_clockto determine if (strictly) future calls to_upand_dnhappen beforeverifyDirectiondesired_directionis set in_upand_dn, checks to make sure it is called in the same tick before preceding, otherwise pushes the call to the end of the I/O queueverifyDirectionfunction which resets the direction, but first checks the parameter with the last set direction, and if different, calls_upor_dndepending on the direction it needs to go in after resetting the direction