Skip to content

Rework instantiation of MotionBuilderConfigOverlay - #208

Merged
rocco8773 merged 9 commits into
mainfrom
rework_MotionBuilderConfigOverlay_init
Jul 2, 2026
Merged

Rework instantiation of MotionBuilderConfigOverlay#208
rocco8773 merged 9 commits into
mainfrom
rework_MotionBuilderConfigOverlay_init

Conversation

@rocco8773

@rocco8773 rocco8773 commented Jul 2, 2026

Copy link
Copy Markdown
Member

Rework the instantiation of MotionBuilderConfigOverlay such that a valid MotionBuilder object is instantiated and linked to the display by the end of __init__.

The generated MotionBuilder object is either a copy of the motion build attached to the given MotionGroup or (if MotionGroup has no motion builder) a default motion builder defined by the _default_motion_builder() method.


  • Reorganize the widget _init_* methods to be list alphabetically.
  • Created _init_motion_builder to do the full MotionBuilder instantiation.
  • Created _init_mspace_display to do the MotionSpaceDisplay instantiation.
  • Created link_motion_builder_to_display to do the associated linking.
  • Morphed _initialized_motion_builder into _default_motion_builder. Now, _init_motion_builder does the full instantiation and _default_motion_builder just gives the default motion builder (as needed).
  • Added kwarg skip_assignment to _spawn_motion_builder so "spawn" can be used by _default_motion_builder and (thus) _init_motion_builder.

@rocco8773
rocco8773 marked this pull request as ready for review July 2, 2026 00:26
@rocco8773
rocco8773 merged commit 519a6c4 into main Jul 2, 2026
17 checks passed
@github-project-automation github-project-automation Bot moved this from Tasks to Done in BaPSF Motion Jul 2, 2026
@rocco8773
rocco8773 deleted the rework_MotionBuilderConfigOverlay_init branch July 2, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant