Repository navigation
fix: preserve URL extensions for generic downloads - #543
Open
rahulshahDEV wants to merge 4 commits into
Open
rahulshahDEV wants to merge 4 commits into
rahulshahDEV wants to merge 4 commits into
Conversation
rickdijk
reviewed
Oct 27, 2026
rickdijk
reviewed
Oct 27, 2026
rickdijk
reviewed
Oct 27, 2026
rickdijk
reviewed
Oct 27, 2026
rickdijk
reviewed
Oct 27, 2026
rickdijk
reviewed
Oct 27, 2026
rahulshahDEV
force-pushed
the
fix/489-extension-fallback
branch
from
October 27, 2026 10:59
8afb8d4 to
69f551a
Compare
rickdijk
reviewed
Oct 28, 2026
| String get fileExtension => mimeTypes[mimeType] ?? '.$subType'; | ||
| } | ||
|
|
||
| final RegExp _safeFileExtension = RegExp(r'^\.[A-Za-z0-9]{1,10}$'); |
Contributor
There was a problem hiding this comment.
Nit, non-blocking: all-digit suffixes still pass, so /api/v1.2 or /reports/q3.2024 served as application/octet-stream are cached as .2 / .2024 instead of .bin (the v1.2-beta test only covers the hyphen case). Requiring at least one letter keeps .mp4, .7z, .3gp working:
Suggested change
| final RegExp _safeFileExtension = RegExp(r'^\.[A-Za-z0-9]{1,10}$'); | |
| final RegExp _safeFileExtension = RegExp(r'^\.(?=[A-Za-z0-9]*[A-Za-z])[A-Za-z0-9]{1,10}$'); |
plus a test for https://example.com/api/v1.2 → .bin.
Contributor
|
Re-reviewed at 69f551a: all earlier comments are addressed and covered by tests. Locally
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix.
When a download response uses
application/octet-stream, the cache manager gives the cached file a.binextension even when its URL ends in a meaningful extension such as.mp4.🆕 What is the new behavior (if this is a feature change)?
Responses with a missing or generic
Content-Typeuse a safe final extension from the URL path; invalid path, control, or platform-reserved characters fall back to the MIME extension (.binfor a generic type). A specific response MIME type remains authoritative, and query parameters do not affect the extension. The legacy adapter follows the same rule. The exportedHttpGetResponse(response)constructor remains supported and uses the response request URL when available.💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
Before this follow-up, format, analyze, and coverage tests passed with Flutter 3.47.4. After the follow-up,
dart format --output=none --set-exit-if-changedpassed for all four changed Dart files; the changed-file analyzer passed; andflutter test --coveragepassed all 118 tests with Flutter 3.49.0-0.1.pre. The added regressions cover one-argument constructor compatibility and an encoded slash in a URL suffix. Package-wide analyze on the available 3.49.0-0.1.pre SDK reports six existing Material migration infos in untouched example/test files; changed files analyze clean. CI should validate the example builds on supported platforms.📝 Links to relevant issues/docs
Closes #489.
🤔 Checklist before submitting