Conversation
| UPDATE_COMMAND "" | ||
| PATCH_COMMAND git clean -fdx | ||
| COMMAND git apply ${CMAKE_CURRENT_LIST_DIR}/0001-Add-CMake-script-for-building-tolk.patch | ||
| PATCH_COMMAND git apply ${CMAKE_CURRENT_LIST_DIR}/0001-Add-CMake-script-for-building-tolk.patch |
There was a problem hiding this comment.
Does this work with MSBuild and Rebuild?
There was a problem hiding this comment.
As mentioned earlier, project files generated by CMake are not suitable for rebuilding. To perform a rebuild, it is recommended to delete the relevant files manually.
There was a problem hiding this comment.
CMake automatically creates a "clean" target which is used for rebuilding. Both Qt Creator and VS2022 use this target when you choose "Rebuild".
There was a problem hiding this comment.
Yes, it is true that the clean target exists. However, due to the nature of External Projects, using the clean target is not appropriate. External Projects store the completion status of each task as a stamp, but the clean target deletes that.
There was a problem hiding this comment.
And now, tolk is no longer used. Since this problem mostly occurred only with tolk, it seems there will be no issues now.
60a3c06 to
189a364
Compare
|
I disagree with this PR. It breaks build on Windows again. More, I suggest to add reset and clean step on Prism, currently we can't rebuild after first Prism build. |
|
Adding For Prism, if a clean rebuild is needed, the recommended approach is to delete its build directory manually rather than relying on the |
@CoBC, the Visual Studio files generated by CMake are not suitable for rebuilding. If you want to rebuild, it would be better to delete the relevant files from the cache.