Skip to content

Android client. Added the forgotan Subscription and transmission changes to the chat list#3312

Merged
hwangsihu merged 3 commits into
BearWare:masterfrom
amirmahdifard:addlog
Jun 19, 2026
Merged

Android client. Added the forgotan Subscription and transmission changes to the chat list#3312
hwangsihu merged 3 commits into
BearWare:masterfrom
amirmahdifard:addlog

Conversation

@amirmahdifard

Copy link
Copy Markdown
Contributor

When I was implementing these announcements in 5.18, because you took so long to review and merge my pull request, I forgot to complete it and add the chatlogs for them as whell like I did for the other things. But now has been fadded

bear101
bear101 previously requested changes Jun 5, 2026

@bear101 bear101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will overflow the chat history. I suggest they should be disabled by default.

Comment thread Client/TeamTalkAndroid/src/main/java/dk/bearware/backend/TeamTalkService.java Outdated
hwangsihu
hwangsihu previously approved these changes Jun 7, 2026
@amirmahdifard amirmahdifard marked this pull request as draft June 7, 2026 10:11
@amirmahdifard amirmahdifard marked this pull request as ready for review June 7, 2026 15:08
@amirmahdifard

Copy link
Copy Markdown
Contributor Author

@hwangsihu I didn't see this statement in main activity I think that's why I forgot to add it at the first place. Thanks! this pr is now ready

@amirmahdifard amirmahdifard requested a review from bear101 June 17, 2026 13:09
amirmahdifard and others added 3 commits June 19, 2026 18:29
onCmdChannelUpdate() logged transmission changes for every channel
update, so changes in channels the user is not in would appear in the
chat history. Restrict it to mychannel, matching the existing
text-to-speech behaviour in MainActivity.onCmdChannelUpdate(), and fix
the stray indentation/spacing in the touched blocks.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@hwangsihu hwangsihu dismissed bear101’s stale review June 19, 2026 10:15

Outdated review

@hwangsihu hwangsihu merged commit e17bfd5 into BearWare:master Jun 19, 2026
12 checks passed
@amirmahdifard amirmahdifard deleted the addlog branch June 19, 2026 18:01
@hwangsihu hwangsihu added this to the TeamTalk v5.23 milestone Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants