Add generic RISC-V build path#403
Open
carlosqwqqwq wants to merge 2 commits into
Open
Conversation
kalvdans
reviewed
Jun 15, 2026
Contributor
There was a problem hiding this comment.
Remove the noisy compiler output for all non-accellerated architectures, as cmake has already warned about it.
Author
There was a problem hiding this comment.
Thank you for pointing this out. I removed the noisy generic fallback warning for all non-accelerated architectures and rechecked the native tests plus the simulated riscv64 build locally; I’m still learning RISC-V, so I really appreciate your guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
c-blosc reported riscv targets as unknown processors and left its generic fallback path noisy in
shuffle.c, even though the generic C implementation was otherwise usable. This patch makes the baseline RISC-V build path explicit while preserving the existing generic implementation.What changed
riscv*targets explicitly in the top-level CMake processor selection instead of reporting them as unknown processors.blosc/shuffle.ctake a quiet generic fallback on RISC-V instead of emitting the non-x86 hardware-acceleration warning.Verification
cmake --build build-codex-native --parallel 4.ctest --test-dir build-codex-native --output-on-failure; all1639/1639tests passed.riscv64CMake configuration withCMAKE_SYSTEM_NAME=Linux,CMAKE_SYSTEM_PROCESSOR=riscv64,CMAKE_TRY_COMPILE_TARGET_TYPE=STATIC_LIBRARY,BUILD_SHARED=OFF,BUILD_STATIC=ON,BUILD_TESTS=OFF,BUILD_FUZZERS=OFF,BUILD_BENCHMARKS=OFF, and forced__riscv=1/__riscv_xlen=64macros because no real RISC-V toolchain is available on the host.riscv64static library successfully withcmake --build build-codex-riscv --parallel 4.build-codex-riscv/build.ninja: it containsshuffle-generic.c,bitshuffle-generic.c,shuffle.c,ZSTD_DISABLE_ASM,__riscv=1, and__riscv_xlen=64.build-codex-riscv/build.ninjadoes not containshuffle-sse2.c,bitshuffle-sse2.c,shuffle-avx2.c,bitshuffle-avx2.c,-msse2,-mavx2, orhuf_decompress_amd64.S.Notes
This is a conservative portability patch. It does not add RVV kernels or any RISC-V-specific performance optimizations. Verification covers native build and test stability plus simulated RISC-V target selection and source/flag exclusion checks, but not a real riscv64 cross-toolchain build or hardware run.