WIP: NeighborOrientationCorrelation unit testing#1600
Draft
mmarineBlueQuartz wants to merge 1 commit intoBlueQuartzSoftware:developfrom
Draft
WIP: NeighborOrientationCorrelation unit testing#1600mmarineBlueQuartz wants to merge 1 commit intoBlueQuartzSoftware:developfrom
mmarineBlueQuartz wants to merge 1 commit intoBlueQuartzSoftware:developfrom
Conversation
Collaborator
mmarineBlueQuartz
commented
Apr 22, 2026
mmarineBlueQuartz
commented
- Refactored the algorithm for better readability. Each method does one thing and reduces the number of loops and conditionals to keep track of how data is being processed. Each additional function is documented for easy readability through an IDE.
- Optimized the algorithm to use AbstractDataStore references instead of DataArrays.
- Reworked the filter and algorithm to use the confidence and min number of acceptable neighbors.
- Fixed a bug where the filter skipped every other pass by decrementing the count twice in each loop.
* Refactored the algorithm for better readability. Each method does one thing and reduces the number of loops and conditionals to keep track of how data is being processed. Each additional function is documented for easy readability through an IDE. * Optimized the algorithm to use AbstractDataStore references instead of DataArrays. * Reworked the filter and algorithm to use the confidence and min number of acceptable neighbors. * Fixed a bug where the filter skipped every other pass by decrementing the count twice in each loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.