Repository navigation
feat: one-shot create-and-seed pool create + mint-at-deploy token fee - #65
Merged
Merged
Conversation
Wire Create Pool to the create-and-seed factory when published (one Express approval). Credit Create Token platform fee in deploy init so fee collection no longer needs a second approval. Co-authored-by: nico.builds <nico.builds@outlook.com>
One Express approval credits the platform fee at deploy; stop promising a separate fee transfer. Also honest Create Pool success when register is skipped. Co-authored-by: nico.builds <nico.builds@outlook.com>
3 tasks
Co-authored-by: nico.builds <nico.builds@outlook.com>
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires Finance to the protocol create-and-seed factory and collapses Create Token fee collection into the deploy tx.
Create Pool
REACT_APP_BOING_NATIVE_CREATE_AND_SEED_FACTORYis set: one Express Batch (wrap? → approve →create_and_seed→add_liquidity)Create Token
Gate (ops)
Do not set
REACT_APP_BOING_NATIVE_CREATE_AND_SEED_FACTORYuntil the factory AccountId is on-chain. Merge after network #169 is onmain(SDK 0.5.40).Depends on boing.network create-and-seed factory + SDK 0.5.40.