Skip to content

修复 ObjectIDAllocator::alloc 中的线程安全隐患、误报 Bug 及冗余原子开销 #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuanjay07 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

修复 ObjectIDAllocator::alloc 中的线程安全隐患、误报 Bug 及冗余原子开销 #514

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4131dda
fix(framework): fix potential race condition and false alarm in Objec…
yuanjay07 Jul 13, 2026
2680523
优化：使用松散内存序自增并增加溢出检测的中文注释
yuanjay07 Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions engine/source/runtime/function/framework/object/object_id_allocator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,12 @@ namespace Piccolo

GObjectID ObjectIDAllocator::alloc()
{
std::atomic<GObjectID> new_object_ret = m_next_id.load();
m_next_id++;
if (m_next_id >= k_invalid_gobject_id)
// 使用松散内存顺序（std::memory_order_relaxed）执行原子自增并返回旧值，性能更优
GObjectID new_object_ret = m_next_id.fetch_add(1, std::memory_order_relaxed);

// 由于 new_object_ret 是自增前的值，判断自增后的值（new_object_ret + 1）是否溢出，
// 等价于判断 new_object_ret 是否大于等于 k_invalid_gobject_id - 1
if (new_object_ret >= k_invalid_gobject_id - 1)
{
LOG_FATAL("gobject id overflow");
}
Expand All @@ -19,3 +22,9 @@ namespace Piccolo
}

} // namespace Piccolo