You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm looking at https://github.com/BurnySc2/python-sc2/blob/develop/sc2/dicts/generic_redirect_abilities.py and trying to figure out when one would want to use ATTACK_ATTACK over ATTACK because the latter is the more generic one.
For example the land command has specific ones for each flying building (Barracks, Factory etc.) however simply LAND would also work.
Currently I am of the opinion that you should always use the generic ability. Can you think of a scenario where the specific command (ability) should be used?
I'm looking at https://github.com/BurnySc2/python-sc2/blob/develop/sc2/dicts/generic_redirect_abilities.py and trying to figure out when one would want to use ATTACK_ATTACK over ATTACK because the latter is the more generic one. For example the land command has specific ones for each flying building (Barracks, Factory etc.) however simply LAND would also work. Currently I am of the opinion that you should always use the generic ability. Can you think of a scenario where the specific command (ability) should be used?
What I read on the discord is that they can behave differently. E.g., if the target is out of range, ATTACK will lead to the unit moving into range, whereas ATTACK_ATTACK would lead to the unit not doing anything. And for medivacs ATTACK gets converted to ATTACK_SCAN so that it moves, but ATTACK_ATTACK again doesn't do anything. I haven't tried this myself though, so you may know better.
edit:
Also just realized that I didn't create a branch and pushed 19c88d1 on accident. I think this would be good to merge too, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think these can be added to COMBINEABLE_ABILITIES, unless there is a good reason why they are not in there?
This could help bring APM down.