Skip to content

Adds MOVE_MOVE and ATTACK_ATTACK to COMBINEABLE_ABILITIES - #230

Closed
maxnus wants to merge 0 commit into
BurnySc2:developfrom
maxnus:develop
Closed

Adds MOVE_MOVE and ATTACK_ATTACK to COMBINEABLE_ABILITIES#230
maxnus wants to merge 0 commit into
BurnySc2:developfrom
maxnus:develop

Conversation

@maxnus

@maxnus maxnus commented Nov 29, 2025

Copy link
Copy Markdown
Contributor

I think these can be added to COMBINEABLE_ABILITIES, unless there is a good reason why they are not in there?
This could help bring APM down.

@BurnySc2

BurnySc2 commented Jan 3, 2026

Copy link
Copy Markdown
Owner

I'm looking at https://github.com/BurnySc2/python-sc2/blob/develop/sc2/dicts/generic_redirect_abilities.py and trying to figure out when one would want to use ATTACK_ATTACK over ATTACK because the latter is the more generic one.
For example the land command has specific ones for each flying building (Barracks, Factory etc.) however simply LAND would also work.
Currently I am of the opinion that you should always use the generic ability. Can you think of a scenario where the specific command (ability) should be used?

@maxnus

maxnus commented Jan 3, 2026

Copy link
Copy Markdown
Contributor Author

I'm looking at https://github.com/BurnySc2/python-sc2/blob/develop/sc2/dicts/generic_redirect_abilities.py and trying to figure out when one would want to use ATTACK_ATTACK over ATTACK because the latter is the more generic one. For example the land command has specific ones for each flying building (Barracks, Factory etc.) however simply LAND would also work. Currently I am of the opinion that you should always use the generic ability. Can you think of a scenario where the specific command (ability) should be used?

What I read on the discord is that they can behave differently. E.g., if the target is out of range, ATTACK will lead to the unit moving into range, whereas ATTACK_ATTACK would lead to the unit not doing anything. And for medivacs ATTACK gets converted to ATTACK_SCAN so that it moves, but ATTACK_ATTACK again doesn't do anything. I haven't tried this myself though, so you may know better.

edit:
Also just realized that I didn't create a branch and pushed 19c88d1 on accident. I think this would be good to merge too, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants