Repository navigation
fix(web): show the register page starting price from live Stripe pricing - #1320
Merged
Merged
Conversation
The line said "from $14/month", the monthly USD Solo price. Pricing now comes from the plan prices endpoint in the visitor's currency, with the regional Solo discount, and defaults to yearly billing per month. The amount is now a live-price element (data-price-plan, year-monthly) that src/scripts/currency.ts fills in, as on the pricing page. The HTML keeps the USD yearly-per-month figure ($12) as a fallback. The copy now says "/mo, billed yearly", matching the homepage pricing teaser. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
riderx
changed the title
riderx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#1318 added "Paid plans from $14/month after the trial." to
/register. That's the monthly USD Solo price, which no longer matches how pricing works: prices load from the plan prices endpoint (#1304) in the visitor's currency, with the regional Solo discount (#1249), and the pricing page defaults to yearly billing shown per month. A visitor whose/pricingshows Solo at €7/mo was told $14.What changed
data-price-plan= the cheapest plan's Stripe product,data-price-interval="year-monthly"). The page callsinitCurrency()fromsrc/scripts/currency.ts, the same code the pricing page uses, so the price always matches/pricing.{price}so the amount stays its own element in every translation.Checks
/pricingshowed Solo at €7 (year-monthly, regional discount from €11).astro check: 0 errors.bun test src/scripts/register.test.ts: 6 pass.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.