Repository navigation
Let Data API writes reach samples pruned after archiving - #108
Merged
Merged
Conversation
Once an experiment is archived and its samples leave the lab, the live sample is pruned. The analysis routes and the measurements POST only looked at the live collection, so analysis results and SEM refs that arrive after that point got a 404. Fall back to the archived copy when the sample is no longer live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prune_archived_unplaced_from_liveremoves the live sample, but/analysis/pending,/analysis/claim,/analysis/resultsandPOST /samples/<id>/measurementsonly look at the live collection. An analysis that finishes after the operator confirms Ending can't be written back, and a SEM ref registered after the sample left the lab gets a 404.Alab(completed)when the live one is gone. Live samples behave the same as before.Additional dependencies introduced (if any)
None.
Checklist
tests/test_analysis_data_api.pyfor a pruned sample (pending, claim, release, result, measurement ref).