fix: harden range sync hashBlocks() - #9686
Open
twoeths wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the hashBlocks utility to uniquely identify a batch attempt by hashing both blocks and payload envelopes (including their signatures) into a single fixed-size buffer using SHA-256, and adds corresponding unit tests. The review feedback suggests two key improvements: replacing Buffer.allocUnsafe with Buffer.alloc to guarantee deterministic hashing and prevent potential uninitialized memory leaks, and passing ChainForkConfig to dynamically resolve fork-specific SSZ types instead of hardcoding ssz.gloas.ExecutionPayloadEnvelope.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
wemeetagain
reviewed
Jul 24, 2026
Comment on lines
+52
to
+53
| for (const [, envelope] of envelopes) { | ||
| const signedEnvelope = envelope.getPayloadEnvelope(); |
Member
There was a problem hiding this comment.
should the payload envelope hash be added to IPayloadInput? Instead of using cachePermanentRootStruct?
Member
Author
There was a problem hiding this comment.
we already have to compute signing root while verifying signature for all payload envelopes here
so using
cachePermanentRootStruct ensures we compute it onceit's not convenient to add a rootHex to
PayloadEnvelopeInput (of beacon-node) because computeSigningRoot() stays on state-transitionso it's different to IBlockInput
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ExecutionPayloadEnveloperoots for cheaper attempt hashingpart of #9667
AI Assistance Disclosure