fix: use payload request limit for envelope byPeer range quota - #9710
Open
ensi321 wants to merge 2 commits into
Open
fix: use payload request limit for envelope byPeer range quota#9710ensi321 wants to merge 2 commits into
ensi321 wants to merge 2 commits into
Conversation
(cherry picked from commit 88b8052)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c422cccc36
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| describe("network / reqresp / rateLimitQuotas", () => { | ||
| it("uses MAX_REQUEST_PAYLOADS for ExecutionPayloadEnvelopesByRange", () => { | ||
| const config = createBeaconConfig(getConfig(ForkName.gloas), ZERO_HASH); |
There was a problem hiding this comment.
With this setup, getConfig(ForkName.gloas) retains defaults where MAX_REQUEST_PAYLOADS and MAX_REQUEST_BLOCKS_DENEB are both 128, so this test also passes against the parent implementation that uses the wrong block limit. Override one limit with a distinct value when creating the config so the test actually fails before the fix and protects against this regression.
AGENTS.md reference: AGENTS.md:L377-L382
Useful? React with 👍 / 👎.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
…the two limits MAX_REQUEST_PAYLOADS and MAX_REQUEST_BLOCKS_DENEB both default to 128, so the test also passed against the previous implementation using the block limit. Verified the test now fails when the quota reads MAX_REQUEST_BLOCKS_DENEB and passes with the fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
nflaig
reviewed
Jul 25, 2026
| it("uses MAX_REQUEST_PAYLOADS for ExecutionPayloadEnvelopesByRange", () => { | ||
| // Override MAX_REQUEST_PAYLOADS to differ from MAX_REQUEST_BLOCKS_DENEB (both default to 128), | ||
| // otherwise this test cannot distinguish the two limits | ||
| const config = createBeaconConfig({...getConfig(ForkName.gloas), MAX_REQUEST_PAYLOADS: 64}, ZERO_HASH); |
Member
There was a problem hiding this comment.
do we really need this test? it's a bit strange and trivial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Port of an outstanding fix from the
glamsterdam-devnet-7branch (#9587) that never landed onunstable.#9050 added the
ExecutionPayloadEnvelopesByRangereq/resp method with abyPeerquota ofMAX_REQUEST_BLOCKS_DENEB(128), while the spec caps envelope range requests atMAX_REQUEST_PAYLOADSper https://github.com/ethereum/consensus-specs/blob/v1.7.0-alpha.12/specs/gloas/p2p-interface.md#executionpayloadenvelopesbyrange-v1. ThegetRequestCountside already usesMAX_REQUEST_PAYLOADS; thebyPeerquota was left inconsistent.Description
config.MAX_REQUEST_PAYLOADSfor theExecutionPayloadEnvelopesByRangebyPeerquotaMAX_REQUEST_PAYLOADSCherry-picked from
glamsterdam-devnet-7(88b8052, original author @nflaig); applied without conflicts.AI Assistance Disclosure
Cherry-pick selection and verification done with AI assistance (Claude Code); original commit authored by @nflaig on the devnet-7 branch.
🤖 Generated with Claude Code