fix: use parent block slot for attestation payload availability - #9731
Merged
Conversation
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Member
Author
|
need |
nflaig
added a commit
that referenced
this pull request
Jul 30, 2026
Member
Author
|
merged into |
twoeths
reviewed
Jul 31, 2026
| : computeBlockAttestationRewardAltair( | ||
| config, | ||
| block as altair.BeaconBlock, | ||
| preState as CachedBeaconStateAltair, |
Member
There was a problem hiding this comment.
we don't apply parent execution payload for preState so executionPayloadAvailability passed in is not correct
but I'd resolve it in a different PR
Member
Author
There was a problem hiding this comment.
not sure I follow correctly, maybe you can make a proposal for that, if you are looking into that right now, can target my branch, I am not sure how to merge this unless we skip a lot of spec tests
twoeths
previously approved these changes
Jul 31, 2026
twoeths
enabled auto-merge (squash)
July 31, 2026 06:46
Member
Author
|
@twoeths we need a spec release to merge this, I could ignore failing spec tests, but it require to skip 59 tests |
nflaig
commented
Aug 1, 2026
| // only the pyspec BLS stub accepts. Lodestar verifies the deposit proof of possession | ||
| // inside processPendingDeposits, so the validator is never onboarded and the state root | ||
| // diverges once the pending deposit is applied. | ||
| name.includes("is_one_confirmed_passes_with_new_validator_activated_in_head_state"), |
Member
Author
There was a problem hiding this comment.
@nazarhussain this might be an issue with the test harness? in any case, I would like to keep this out of this PR, so skipping for now
nflaig
commented
Aug 1, 2026
| // TODO-GLOAS: re-enable after the gloas should_apply_proposer_boost rule is implemented. | ||
| // New test suite added in v1.7.0-alpha.13 (consensus-specs #5441); Lodestar still applies | ||
| // the pre-gloas proposer boost, so the head weight differs by the boost amount. | ||
| /^gloas\/fork_choice\/should_apply_proposer_boost\/.*$/, |
Member
Author
There was a problem hiding this comment.
@ensi321 looks like we are failing the new tests you added in ethereum/consensus-specs#5441
nflaig
commented
Aug 1, 2026
| - get_weight#gloas | ||
| - has_compounding_withdrawal_credential#gloas | ||
| - is_ancestor#gloas | ||
| - is_bid_compatible_with_head#gloas |
Member
Author
There was a problem hiding this comment.
well we do have this, but it's in a different pr here #9739 and not approved, so no way I can fix this now
twoeths
approved these changes
Aug 3, 2026
markolazic01
pushed a commit
to markolazic01/lodestar
that referenced
this pull request
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.7.0-alpha.13