Fix silent error swallowing in session#1032
Closed
gjmulhol wants to merge 1 commit into
Closed
Conversation
- Replace silent ValueError pass with logger.debug for 401 JSON parsing (was completely invisible to users/developers) - Downgrade AttributeError from logger.error to logger.debug (this is an expected case, not a true error) - Upgrade JSONDecodeError in _extract_response_json from logger.info to logger.warning (returning empty dict silently can cause confusing downstream failures) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
Consolidated into docs/improve-sdk-documentation branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
passon ValueError withlogger.debugfor 401 JSON parsing attemptslogger.errortologger.debug(expected case, not an error)_extract_response_jsonfromlogger.infotologger.warning(returning empty dict silently can cause confusing downstream failures)Test plan
🤖 Generated with Claude Code
PR 6 of 11. Independent — no dependencies on other PRs.