Split npm publish out of sync.yml into its own manually-triggered workflow - #1
Merged
Merged
Conversation
sync.yml pushes commits and tags directly to main; with branch protection now requiring PR review on main, that push would fail for identities other than the allowed bypass user. It also can't publish to npm yet since no auth is configured (trusted publisher can only be set up once a first version exists on the registry). Keep sync.yml focused on syncing, committing, tagging, and creating GitHub releases. Add publish.yml as a manually-triggered (workflow_dispatch) workflow that publishes a given tag to npm via OIDC trusted publishing, mirroring click-ui's OIDC-only approach (https://github.com/ClickHouse/click-ui/blob/main/.github/workflows/publish.yml) rather than keeping a long-lived NPM_TOKEN fallback. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
alexey-milovidov
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync.ymlno longer publishes to npm. It still syncs, rebuilds, tests, commits, tags, and creates the GitHub release exactly as before.publish.yml: manually triggered (workflow_dispatch, requires arefinput — e.g.v1.0.1), runs the test suite against the checked-out tag, then publishes via npm OIDC trusted publishing (noNPM_TOKEN, no long-lived secrets).Why
mainnow has branch protection requiring PR review;sync.yml's directgit push --follow-tagsonly works for identities on the bypass list, so it made sense to stop bundling an npm-auth-dependent step into that same job.Next steps (after merge)
npm login && npm publish --access public) from a local checkout — one-time, since Trusted Publisher can't be configured before the package exists on npm.@clickhouse/lexer: GitHub Actions, orgClickHouse, repoclickhouse-lexer, workflowpublish.yml.Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com