Skip to content

fix: Ensure atomic credential changes and session revocation in EF Core - #103

Merged
mckaragoz merged 1 commit into
CodeBeamOrg:devfrom
mckaragoz:EFCoreTransactionFix
Oct 24, 2026
Merged

mckaragoz merged 1 commit into
CodeBeamOrg:devfrom
mckaragoz:EFCoreTransactionFix

Conversation

@mckaragoz

Copy link
Copy Markdown
Contributor

Summary

Fixes #96.

  • Ensure EfCoreSessionStore.ExecuteAsync participates in an existing transaction instead of creating nested transactions.
  • Execute credential-related session revocation within the session store's execution scope.
  • Use IUAuthAtomicExecutor to make password changes and successful password resets atomic.
  • Improve EF Core atomic execution with execution strategy support.
  • Add regression tests covering transaction commits, rollbacks, and cross-store transaction participation.

This prevents partial credential updates and session revocation inconsistencies when an operation fails.

@codecov-commenter

codecov-commenter commented Oct 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.13%. Comparing base (4ea5974) to head (5429929).

Files with missing lines Patch % Lines
....Reference/Services/CredentialManagementService.cs 93.75% 3 Missing and 1 partial ⚠️
...s.EntityFrameworkCore/Stores/EfCoreSessionStore.cs 84.00% 3 Missing and 1 partial ⚠️
...rkCore/Infrastructure/EfCoreUAuthAtomicExecutor.cs 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #103      +/-   ##
==========================================
+ Coverage   86.03%   86.13%   +0.10%     
==========================================
  Files         665      665              
  Lines       18364    18382      +18     
  Branches     2253     2249       -4     
==========================================
+ Hits        15799    15834      +35     
+ Misses       1810     1795      -15     
+ Partials      755      753       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mckaragoz
mckaragoz merged commit dcca59e into CodeBeamOrg:dev Oct 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Password Change Do Not Work On EntityFrameworkCore

2 participants