Feature/scanner UI - #731
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unescaped finding data enables script injection, while streaming and configuration issues can omit or misroute findings.
Review effort: Balanced
Findings: 1
Open (8)
Unsanitized finding data enables stored XSS · New Add webui to generated common configuration flags · New Emit completion event when scans finish · New Handle http.ErrServerClosed during normal shutdown · New Unregister global hit sink when server closes · New Use unique server-generated IDs for findings · New Prevent silent loss of findings on client queue overflow · New Release findings lock before network replay · New
What changed in this PR
Adds an optional authenticated local web UI for viewing live secret-scan findings.
Changes:
- Adds SSE-based findings display, filtering, and CSV export.
- Introduces a logging hit sink for forwarding findings.
- Wires
--webuiinto supported scan commands.
| File | Description |
|---|---|
pkg/webui/server.go |
Implements the web UI server and streaming. |
pkg/webui/server_test.go |
Tests authentication, rendering, and CSV export. |
pkg/logging/hit.go |
Adds structured hit-sink support. |
pkg/logging/hit_sink_test.go |
Tests hit forwarding. |
pkg/gitlab/enum/export_html.go |
Exposes the embedded logo. |
pkg/config/scan_options.go |
Adds the WebUI scan option. |
internal/cmd/flags/common.go |
Defines the shared --webui flag. |
internal/cmd/jenkins/scan/scan.go |
Integrates the UI with Jenkins scans. |
internal/cmd/gitlab/tf/tf.go |
Integrates the UI with Terraform scans. |
internal/cmd/gitlab/snippets/scan/scan.go |
Integrates the UI with snippet scans. |
internal/cmd/gitlab/scanpublic/scan_public.go |
Integrates the UI with public scans. |
internal/cmd/gitlab/scan/scan.go |
Integrates the UI with GitLab scans. |
internal/cmd/gitlab/cicd/scan/scan.go |
Integrates the UI with CI/CD scans. |
internal/cmd/github/scan/scan.go |
Integrates the UI with GitHub scans. |
internal/cmd/gitea/scan/scan.go |
Integrates the UI with Gitea scans. |
internal/cmd/devops/scan/scan.go |
Integrates the UI with DevOps scans. |
internal/cmd/circle/scan/scan.go |
Integrates the UI with CircleCI scans. |
internal/cmd/bitbucket/scan/scan.go |
Integrates the UI with Bitbucket scans. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.