Add Gitea repository sorting and enhance WebUI - #732
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The elapsed timer can overstate scan duration when completion delivery is delayed, and lifecycle documentation and coverage need correction.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Adds live scan timing and clearer empty states to the findings UI, alongside updated scanning and verification documentation.
Changes:
- Tracks and displays elapsed scan time.
- Distinguishes active, completed, and filtered empty states.
- Documents the web UI and simplifies verification guidance.
| File | Description |
|---|---|
pkg/webui/server.go |
Adds elapsed timing and empty-state behavior. |
pkg/webui/server_test.go |
Adds template-level assertions. |
docs/introduction/secrets_verification.md |
Updates verification behavior documentation. |
docs/guides/scanning.md |
Documents using the live findings UI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
--repo-sortand--repo-orderfor Gitea scans of all accessible repositories, supportingalpha,created,updated,size, andid, withupdated/descdefaults.high-verifieddefault threshold, aNoneoption, and handling for queued notifications when the threshold changes.Tests
go test ./internal/cmd/gitea/scan ./pkg/gitea/scango test ./pkg/webui