fix(release): correct the GHCR pull tag in Release notes#3
Merged
Conversation
metadata-action's {{version}} publishes v-stripped image tags (tag v1.1.0 →
:1.1.0), but the generated Release notes used github.ref_name (v1.1.0) in the
docker pull commands, so the copy-paste pull 404'd on every Release page. Derive
a v-stripped version output and reference it in the pull lines.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata-action's{{version}}publishes v-stripped image tags (git tagv1.1.0→ image:1.1.0), but the generated Release notes usedgithub.ref_name(v1.1.0) in thedocker pullcommands — so the copy-paste pull on every Release page 404s.verstep that derivesversion=${GITHUB_REF_NAME#v}and reference:${{ steps.ver.outputs.version }}in the two pull lines. Release title staysv1.1.0.Verified out-of-band:
docker pull ghcr.io/cryptojones/osapplytrack-{api,poller}:1.1.0and:latestpull clean anonymously;:v1.1.0does not exist.Test plan
release.ymlparses; pull lines now reference the stripped version.ci.ymlruns green on this PR.v*tag (tag-only trigger; not exercised by this PR).🤖 Generated with Claude Code