Skip to content

Php 8 compatibility and minor bug fix #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adarshkhatri wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Php 8 compatibility and minor bug fix #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ec0997
PHP 8.3 compatibility
adarshkhatri Aug 5, 2026
2727a53
bug fix | $this is not available in static function
adarshkhatri Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Api/OAuthApi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function __construct(\CyberSource\ApiClient $apiClient = null)
$this->apiClient = $apiClient;

if (self::$logger === null) {
self::$logger = (new LogFactory())->getLogger(\CyberSource\Utilities\Helpers\ClassHelper::getClassName(get_class()), $apiClient->merchantConfig->getLogConfiguration());
self::$logger = (new LogFactory())->getLogger(\CyberSource\Utilities\Helpers\ClassHelper::getClassName(get_class($this)), $apiClient->merchantConfig->getLogConfiguration());
}
}

Expand Down
2 changes: 1 addition & 1 deletion lib/ObjectSerializer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ public static function deserialize($data, $class, $httpHeaders = null)
$deserialized = new \SplFileObject($filename, "w");
$byte_written = $deserialized->fwrite($data);
if (Configuration::getDefaultConfiguration()->getLogConfiguration()->isLoggingEnabled()) {
$tempLogger = (new LogFactory())->getLogger(\CyberSource\Utilities\Helpers\ClassHelper::getClassName(get_class($this)), Configuration::getDefaultConfiguration()->getLogConfiguration());
$tempLogger = (new LogFactory())->getLogger(\CyberSource\Utilities\Helpers\ClassHelper::getClassName(__CLASS__), Configuration::getDefaultConfiguration()->getLogConfiguration());
$tempLogger->debug("Written $byte_written byte to $filename. Please move the file to a proper folder or delete the temp file after processing.");
$tempLogger->close();
}
Expand Down