Repository navigation
fix(ios): remove private netinet6/in6.h import from cordova-plugin-advanced-http - #57
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses iOS build failures on newer Xcode/iPhoneOS SDKs by patching an unmaintained Cordova plugin dependency to stop importing a now-private Darwin header (<netinet6/in6.h>), relying instead on <netinet/in.h> which already provides the needed declarations.
Changes:
- Adds a
patch-packagepatch forcordova-plugin-advanced-http@3.2.2removing#import <netinet6/in6.h>from two vendored AFNetworking fork files. - Ensures
npm ci+ existingpostinstall: patch-packageflow applies the fix before Capacitor sync copies plugins into iOS.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iOS build fails on the Capawesome Cloud runner since it moved to Xcode 26.5 / iPhoneOS26.5.sdk:
cordova-plugin-advanced-http@3.2.2ships a vendored AFNetworking fork that imports<netinet6/in6.h>directly inSM_AFHTTPSessionManager.mandSM_AFNetworkReachabilityManager.m. The newer SDK marks that header as private to the Darwin module, so clang hard-errors on it. The import is redundant anyway —<netinet/in.h>, which both files already import, provides the same declarations.The plugin is unmaintained (latest release
3.3.1, published 2022), so an upgrade does not fix this.Changes
patch-packagepatch removing the redundant#import <netinet6/in6.h>from both files.The existing
postinstall: patch-packagehook applies it, sonpm ciproduces the fixed sources beforecap synccopies them intoios/capacitor-cordova-ios-plugins.Verification
npx patch-packagere-applies all patches cleanly.