Repository navigation
[201411108] Onboarding - #2894
Merged
Merged
Conversation
Contributor
|
🤖 AI 리뷰(알고리즘 패턴, 시간/공간 복잡도, 학습 현황) 결과는 Checks 탭에서 볼 수 있어요. |
DaleSeo
self-requested a review
November 3, 2026 01:31
DaleSeo
approved these changes
Nov 3, 2026
Comment on lines
+8
to
+9
| if ord(char) >= 65 and ord(char) <= 90: | ||
| result.append(chr(ord(char) + 32)) |
Member
There was a problem hiding this comment.
65, 90, 32가 같은 숫자가 무엇을 뜻하는지 문자 리터럴로 표현하면 더 읽기가 편했을 것 같아요 😀
Suggested change
| if ord(char) >= 65 and ord(char) <= 90: | |
| result.append(chr(ord(char) + 32)) | |
| if 'A' <= char <= 'Z': | |
| result.append(chr(ord(char) + ord('a') - ord('A'))) |
Contributor
Author
There was a problem hiding this comment.
리뷰 감사드립니다! python을 오랜만에 쓰는데 많은 것들이 새로 생긴 것 같더라고요.
앞으로 가독성에도 신경쓰면서 작성해보겠습니다!
Collaborator
|
@201411108 수고하셨습니다. 검토자 체크리스트 확인 부탁드리고, 직전 PR인 #2893 리뷰 부탁드립니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!