Repository navigation
[Tracer] Make DD_DOTNET_TRACER_HOME optional in the managed loader - #7767
lucaspimentel wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7767) and master. ✅ No regressions detected |
andrewlock
left a comment
There was a problem hiding this comment.
LGTM (assuming direct revert, I didn't re-review) as long as you've done an "all products" run in CI 🙂
This comment has been minimized.
This comment has been minimized.
ab2ab63 to
2dbbeaf
Compare
BenchmarksBenchmark execution time: 2026-10-26 20:29:16 Comparing candidate commit aff747b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 10 known flaky benchmarks, 116 flaky benchmarks without significant changes.
|
2dbbeaf to
fd6e208
Compare
DD_DOTNET_TRACER_HOME optional in managed loader"DD_DOTNET_TRACER_HOME optional in managed loader"
fd6e208 to
7f35d84
Compare
7f35d84 to
550b689
Compare
550b689 to
667b40a
Compare
667b40a to
f50dca2
Compare
f50dca2 to
08bd14b
Compare
08bd14b to
960b40a
Compare
960b40a to
4d72fee
Compare
4d72fee to
8f638e4
Compare
DD_DOTNET_TRACER_HOME optional in managed loader"DD_DOTNET_TRACER_HOME optional in managed loader"
8f638e4 to
c8c2fb2
Compare
8210b56 to
6e940a3
Compare
ee35dcf to
651608d
Compare
DD_DOTNET_TRACER_HOME optional in managed loader"DD_DOTNET_TRACER_HOME optional in the managed loader
cfd0900 to
585558d
Compare
Covers the production-style configuration where both native loader components are loaded, the managed SDK is initialized, and profiling is activated through the default managed activation path while span generation is disabled (DD_TRACE_ENABLED=0). Asserts exported profiles contain samples, no trace requests are sent, and the native profiler accepts the managed Stable Configuration instead of using the managed-activation kill switch.
585558d to
aff747b
Compare
Summary of changes
DD_DOTNET_TRACER_HOMEoptional by deriving the managed tracer's location from the native profiler path when it is unset.Reason for change
DD_DOTNET_TRACER_HOMEoptional in managed loader #7568, which was reverted in Revert "makeDD_DOTNET_TRACER_HOMEoptional in managed loader (#7568)" #7704 after Continuous Profiling integration test failures.Implementation details
DD_DOTNET_TRACER_HOME, then architecture-specificCOR_PROFILER_PATH_*/CORECLR_PROFILER_PATH_*, then the unqualified profiler path. Resolve recognized OS/architecture subdirectories back to the tracer home.PROFILERin test loader configs; includeTRACERonly after explicit opt-in, independently ofDD_TRACE_ENABLED.Test coverage
DD_DOTNET_TRACER_HOME; add unit coverage for profiler-test component opt-in.Other details