Repository navigation
[Debugger] DEBUG-5960 Redact index keys computed from constants - #9536
Draft
dudikeleti wants to merge 2 commits into
Draft
dudikeleti wants to merge 2 commits into
dudikeleti wants to merge 2 commits into
Conversation
Fold index keys that depend only on constants once at compile time, then apply the literal-key redaction check. Unredacted keys are replaced by the folded constant, so evaluation no longer recomputes them.
BenchmarksBenchmark execution time: 2026-10-27 19:47:57 Comparing candidate commit 2cc50c3 in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 69 metrics, 0 unstable metrics, 13 known flaky benchmarks, 113 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (9536) and master. ✅ No regressions detected |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
indexkeys computed only from constants, for example{"index":[{"ref":"user"},{"substring":["xpasswordx",1,9]}]}, are folded when the expression compiles and then redacted like literal keys.substringon every hit.Reason for change
ConstantExpressionkeys were checked for redaction, so a key computed from constants returned the raw value. system-teststest_pii_redaction_log_probe_computed_keyis markedbug (DEBUG-5960)for .NET.Implementation details
GetItemAtIndexfolds a string key that isn't a constant before the existing literal-key check.FoldableKeyVisitorstrips the parser's budget checks and accepts only an allowlist: string, primitive and null constants; blocks without variables; unary and binary nodes over primitives without operator methods; conditionals; and members and methods declared onstring. Anything else, including parameters, static members and other calls, keeps today's behavior.Test coverage
substring, render{redacted}with one redaction error.lenis still evaluated at runtime.dotnet test tracer/test/Datadog.Trace.Tests/Datadog.Trace.Tests.csproj -c Release -f net10.0 --filter "FullyQualifiedName~Datadog.Trace.Tests.Debugger": 893 passed, 2 skipped.-f net48: 857 passed, 29 skipped.Other details
{redacted}segment collapse this uses.@it) are still not checked. A runtime guard for them adds one keyword lookup per evaluation of thatindexand will be a separate PR, after the lock-free redaction cache PR.test_pii_redaction_log_probe_computed_keycan be enabled in system-tests.