Skip to content

[Debugger] Gate template dumps on the runtime type #9541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dudikeleti wants to merge 7 commits into
base: dudik/fix/debug-5963-dump-root-dictionary
Choose a base branch
from
+847 −173
Draft

[Debugger] Gate template dumps on the runtime type #9541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ef5f7cf
[Debugger] Gate template dump enumeration and ToString on the runtime…
dudikeleti Oct 27, 2026
7f07cb1
[Debugger] Redact template dumps by runtime type when the declared ty…
dudikeleti Oct 27, 2026
e591a8b
[Debugger] Call exception members in template dumps only on CoreLib r…
dudikeleti Oct 27, 2026
8323e2b
[Debugger] Name dumped exceptions by runtime type and decide more dum…
dudikeleti Oct 27, 2026
9a6ecf6
[Debugger] Read the message field of CoreLib exceptions whose Message…
dudikeleti Oct 27, 2026
0a8b7fa
[Debugger] Cover the compile-time collection and exception dump branches
dudikeleti Oct 27, 2026
eab13a9
[Debugger] Add ReflectionTypeLoadException to the trimming descriptor
dudikeleti Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tracer/src/Datadog.Trace.Trimming/build/Datadog.Trace.Trimming.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,7 @@
<type fullname="System.Reflection.ParameterModifier" />
<type fullname="System.Reflection.PropertyAttributes" />
<type fullname="System.Reflection.PropertyInfo" />
<type fullname="System.Reflection.ReflectionTypeLoadException" />
<type fullname="System.Reflection.RuntimeReflectionExtensions" />
<type fullname="System.Reflection.TargetInvocationException" />
<type fullname="System.Reflection.TargetParameterCountException" />
Expand Down
250 changes: 203 additions & 47 deletions tracer/src/Datadog.Trace/Debugger/Expressions/ProbeExpressionParser.Dump.cs
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 0 additions & 5 deletions tracer/src/Datadog.Trace/Debugger/Expressions/ProbeExpressionParser.General.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,11 +593,6 @@ private ParameterExpression GetParameterExpression(List<ParameterExpression> par
}
}

private bool IsSafeException(Type type)
{
return typeof(Exception).IsAssignableFrom(type) && IsMicrosoftType(type);
}

private bool IsMicrosoftType(Type type)
{
var @namespace = type.Namespace;
Expand Down
451 changes: 451 additions & 0 deletions tracer/test/Datadog.Trace.Tests/Debugger/DebuggerExpressionLanguageTests.cs
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...ionsResources/Approvals/DebuggerExpressionLanguageTests.AccessNullableStruct.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Expressions: (
var StringArg = (string)scopeMemberArray[18].Value;
var CollectionArg = (List<string>)scopeMemberArray[19].Value;
var NestedObjectArg = (DebuggerExpressionLanguageTests.TestStruct.NestedObject)scopeMemberArray[20].Value;
var $dd_el_result = (this.NullableNullValue == null)
var $dd_el_result = !this.NullableNullValue.HasValue
? "null"
: {
fieldsArray = ProbeExpressionParser<string>
Expand Down
2 changes: 1 addition & 1 deletion ...ources/Approvals/DebuggerExpressionLanguageTests.AccessNullableStructNotNull.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Expressions: (
var StringArg = (string)scopeMemberArray[18].Value;
var CollectionArg = (List<string>)scopeMemberArray[19].Value;
var NestedObjectArg = (DebuggerExpressionLanguageTests.TestStruct.NestedObject)scopeMemberArray[20].Value;
var $dd_el_result = (this.NullableNotNullValue == null)
var $dd_el_result = !this.NullableNotNullValue.HasValue
? "null"
: {
fieldsArray = ProbeExpressionParser<string>
Expand Down
126 changes: 87 additions & 39 deletions ...obeExpressionsResources/Approvals/DebuggerExpressionLanguageTests.Collection.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ Expressions: (
{
string loopItem;
IEnumerator<string> enumerator;
int index;
StringBuilder itemValues;
int index, index2;
StringBuilder itemValues, fieldValues;
FieldInfo[] fieldsArray;
var this = (scopeMember.Value == null)
? default(DebuggerExpressionLanguageTests.TestStruct)
: (DebuggerExpressionLanguageTests.TestStruct)scopeMember.Value;
Expand Down Expand Up @@ -42,49 +43,96 @@ Expressions: (
var StringArg = (string)scopeMemberArray[18].Value;
var CollectionArg = (List<string>)scopeMemberArray[19].Value;
var NestedObjectArg = (DebuggerExpressionLanguageTests.TestStruct.NestedObject)scopeMemberArray[20].Value;
var $dd_el_result = (this.Collection == null)
? "null"
: {
enumerator = this.Collection.GetEnumerator();
index = 0;
itemValues = new StringBuilder();
itemValues.Append("[");
while (true)
{
if (enumerator.MoveNext())
{
string loopItem;
var $dd_el_result =
{
var dumpValue = (object)this.Collection;

if (index < 3)
{
if (index > 0)
return (dumpValue == null)
? "null"
: ProbeExpressionParser<string>.IsRedactedRuntimeValue(dumpValue, typeof(List<string>))
? "{redacted}"
: (dumpValue.GetType() == typeof(List<string>))
? {
enumerator = ((List<string>)dumpValue).GetEnumerator();
index = 0;
itemValues = new StringBuilder();
itemValues.Append("[");
while (true)
{
return itemValues.Append(", ");
if (enumerator.MoveNext())
{
string loopItem;

if (index < 3)
{
if (index > 0)
{
return itemValues.Append(", ");
}

loopItem = enumerator.Current;
itemValues.Append(ProbeExpressionParser<string>.DumpObject(
loopItem,
typeof(string),
"",
1));
index++;
}
else
{
itemValues.Append(", ...");
break;
}
}
else
{
break;
}
}
itemValues.Append("]");

loopItem = enumerator.Current;
itemValues.Append(ProbeExpressionParser<string>.DumpObject(
loopItem,
typeof(string),
"",
1));
index++;
return itemValues.ToString();
}
else
{
itemValues.Append(", ...");
break;
}
}
else
{
break;
}
}
itemValues.Append("]");
: {
fieldsArray = ProbeExpressionParser<string>
.GetSafeFieldsForDump(
dumpValue.GetType().GetFields(
BindingFlags.DeclaredOnly | BindingFlags.Instance | BindingFlags.Static | BindingFlags.Public | BindingFlags.NonPublic))
.OrderBy(fieldInfo => fieldInfo.MetadataToken)
.ToArray();
fieldValues = new StringBuilder();
index2 = 0;
while (true)
{
if ((index2 < fieldsArray.Length) && (index2 < 5))
{
fieldValues.Append(
ProbeExpressionParser<string>.DumpObject(
ProbeExpressionParser<string>.GetFieldValueForDump(fieldsArray[index2], (object)dumpValue),
fieldsArray[index2].FieldType,
fieldsArray[index2].Name,
0));
index2++;

if ((index2 < fieldsArray.Length) && (index2 < 5))
{
return fieldValues.Append(", ");
}
}
else
{
if (index2 < fieldsArray.Length)
{
return fieldValues.Append(", ...");
}

break;
}
}

return itemValues.ToString();
};
return fieldValues.ToString();
};
};

return $dd_el_result;
}
Expand Down
85 changes: 46 additions & 39 deletions ...ssionsResources/Approvals/DebuggerExpressionLanguageTests.CustomArrayAtIndex.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,49 +46,56 @@ Expressions: (
var StringArg = (string)scopeMemberArray[18].Value;
var CollectionArg = (List<string>)scopeMemberArray[19].Value;
var NestedObjectArg = (DebuggerExpressionLanguageTests.TestStruct.NestedObject)scopeMemberArray[20].Value;
var $dd_el_result = (((DebuggerExpressionLanguageTests.TestStruct.NestedObject)CustomArrayLocal[0]) == null)
? "null"
: {
fieldsArray = ProbeExpressionParser<string>
.GetSafeFieldsForDump(
((DebuggerExpressionLanguageTests.TestStruct.NestedObject)CustomArrayLocal[0]).GetType().GetFields(
BindingFlags.DeclaredOnly | BindingFlags.Instance | BindingFlags.Static | BindingFlags.Public | BindingFlags.NonPublic))
.OrderBy(fieldInfo => fieldInfo.MetadataToken)
.ToArray();
fieldValues = new StringBuilder();
index = 0;
while (true)
{
if ((index < fieldsArray.Length) && (index < 5))
{
fieldValues.Append(
ProbeExpressionParser<string>.DumpObject(
ProbeExpressionParser<string>.GetFieldValueForDump(
fieldsArray[index],
(object)((DebuggerExpressionLanguageTests.TestStruct.NestedObject)CustomArrayLocal[0])),
fieldsArray[index].FieldType,
fieldsArray[index].Name,
0));
index++;
var $dd_el_result =
{
var dumpValue = (object)((DebuggerExpressionLanguageTests.TestStruct.NestedObject)CustomArrayLocal[0]);

if ((index < fieldsArray.Length) && (index < 5))
return (dumpValue == null)
? "null"
: ProbeExpressionParser<string>.IsRedactedRuntimeValue(
dumpValue,
typeof(DebuggerExpressionLanguageTests.TestStruct.NestedObject))
? "{redacted}"
: {
fieldsArray = ProbeExpressionParser<string>
.GetSafeFieldsForDump(
dumpValue.GetType().GetFields(
BindingFlags.DeclaredOnly | BindingFlags.Instance | BindingFlags.Static | BindingFlags.Public | BindingFlags.NonPublic))
.OrderBy(fieldInfo => fieldInfo.MetadataToken)
.ToArray();
fieldValues = new StringBuilder();
index = 0;
while (true)
{
return fieldValues.Append(", ");
}
}
else
{
if (index < fieldsArray.Length)
{
return fieldValues.Append(", ...");
}
if ((index < fieldsArray.Length) && (index < 5))
{
fieldValues.Append(
ProbeExpressionParser<string>.DumpObject(
ProbeExpressionParser<string>.GetFieldValueForDump(fieldsArray[index], (object)dumpValue),
fieldsArray[index].FieldType,
fieldsArray[index].Name,
0));
index++;

break;
}
}
if ((index < fieldsArray.Length) && (index < 5))
{
return fieldValues.Append(", ");
}
}
else
{
if (index < fieldsArray.Length)
{
return fieldValues.Append(", ...");
}

break;
}
}

return fieldValues.ToString();
};
return fieldValues.ToString();
};
};

return $dd_el_result;
}
Expand Down
15 changes: 11 additions & 4 deletions ...robeExpressionsResources/Approvals/DebuggerExpressionLanguageTests.Exception.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,17 @@ Expressions: (
var StringArg = (string)scopeMemberArray[18].Value;
var CollectionArg = (List<string>)scopeMemberArray[19].Value;
var NestedObjectArg = (DebuggerExpressionLanguageTests.TestStruct.NestedObject)scopeMemberArray[20].Value;
var $dd_el_result = (@exception == null)
? "System.Exception"
: "System.Exception" + ", " + @exception.Message + ", " + @exception.StackTrace;
var $dd_el_result =
{
var dumpValue = (object)@exception;

return (dumpValue == null)
? "System.Exception"
: ProbeExpressionParser<string>.IsRedactedRuntimeValue(dumpValue, typeof(Exception))
? "{redacted}"
: ProbeExpressionParser<string>.DumpException((Exception)dumpValue, null);
};

return $dd_el_result;
}
Result: The result of the expression is: System.Exception, Can not cast X to Y,
Result: The result of the expression is: System.InvalidCastException, Can not cast X to Y,
83 changes: 46 additions & 37 deletions ...ionsResources/Approvals/DebuggerExpressionLanguageTests.ToStringNotSupported.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,47 +41,56 @@ Expressions: (
var StringArg = (string)scopeMemberArray[18].Value;
var CollectionArg = (List<string>)scopeMemberArray[19].Value;
var NestedObjectArg = (DebuggerExpressionLanguageTests.TestStruct.NestedObject)scopeMemberArray[20].Value;
var $dd_el_result = (this.Nested == null)
? "null"
: {
fieldsArray = ProbeExpressionParser<string>
.GetSafeFieldsForDump(
this.Nested.GetType().GetFields(
BindingFlags.DeclaredOnly | BindingFlags.Instance | BindingFlags.Static | BindingFlags.Public | BindingFlags.NonPublic))
.OrderBy(fieldInfo => fieldInfo.MetadataToken)
.ToArray();
fieldValues = new StringBuilder();
index = 0;
while (true)
{
if ((index < fieldsArray.Length) && (index < 5))
{
fieldValues.Append(
ProbeExpressionParser<string>.DumpObject(
ProbeExpressionParser<string>.GetFieldValueForDump(fieldsArray[index], (object)this.Nested),
fieldsArray[index].FieldType,
fieldsArray[index].Name,
0));
index++;
var $dd_el_result =
{
var dumpValue = (object)this.Nested;

if ((index < fieldsArray.Length) && (index < 5))
return (dumpValue == null)
? "null"
: ProbeExpressionParser<string>.IsRedactedRuntimeValue(
dumpValue,
typeof(DebuggerExpressionLanguageTests.TestStruct.NestedObject))
? "{redacted}"
: {
fieldsArray = ProbeExpressionParser<string>
.GetSafeFieldsForDump(
dumpValue.GetType().GetFields(
BindingFlags.DeclaredOnly | BindingFlags.Instance | BindingFlags.Static | BindingFlags.Public | BindingFlags.NonPublic))
.OrderBy(fieldInfo => fieldInfo.MetadataToken)
.ToArray();
fieldValues = new StringBuilder();
index = 0;
while (true)
{
return fieldValues.Append(", ");
}
}
else
{
if (index < fieldsArray.Length)
{
return fieldValues.Append(", ...");
}
if ((index < fieldsArray.Length) && (index < 5))
{
fieldValues.Append(
ProbeExpressionParser<string>.DumpObject(
ProbeExpressionParser<string>.GetFieldValueForDump(fieldsArray[index], (object)dumpValue),
fieldsArray[index].FieldType,
fieldsArray[index].Name,
0));
index++;

break;
}
}
if ((index < fieldsArray.Length) && (index < 5))
{
return fieldValues.Append(", ");
}
}
else
{
if (index < fieldsArray.Length)
{
return fieldValues.Append(", ...");
}

break;
}
}

return fieldValues.ToString();
};
return fieldValues.ToString();
};
};

return $dd_el_result;
}
Expand Down
Loading