Repository navigation
[Debugger] Remove the unused adaptive cache - #9543
dudikeleti wants to merge 1 commit into
Conversation
BenchmarksBenchmark execution time: 2026-10-28 11:04:36 Comparing candidate commit 134c6d4 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 68 metrics, 1 unstable metrics, 11 known flaky benchmarks, 115 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (9543) and master. ✅ No regressions detected |
Summary of changes
tracer/src/Datadog.Trace/Debugger/Caching/:ConcurrentAdaptiveCache, its eviction policies, memory and environment checkers) and its tests.WindowsMemoryInfo.TryGetAvailablePhysicalMemoryand its test. Its only caller was the deleted memory checker.Reason for change
Redactionno longer usesConcurrentAdaptiveCache, and nothing else did. Each cache instance also started a background cleanup task, so keeping the type around invites reuse of a design that took a process-wide write lock on every hit.Implementation details
git grepat the head finds no references to the removed types, theDatadog.Trace.Debugger.Cachingnamespace orTryGetAvailablePhysicalMemory, apart from historicaldocs/CHANGELOG.mdentries.CompileManagedLoader CreateTrimmingFile) produces no change toDatadog.Trace.Trimming.xml.WindowsMemoryInfo.TryGetMemoryLoadRatiostays;SystemMemorySourcestill uses it.Test coverage
dotnet build -c ReleaseofDatadog.Tracefor net461, netstandard2.0, netcoreapp3.1 and net6.0: no warnings.dotnet test tracer/test/Datadog.Trace.Tests/Datadog.Trace.Tests.csproj -c Release -f net10.0 --filter "FullyQualifiedName~Datadog.Trace.Tests.Debugger": 868 passed, 2 skipped.-f net48: 831 passed, 29 skipped.Other details