Skip to content

Tuple transform refactoring#468

Open
alex-kulakov wants to merge 71 commits intomasterfrom
tuple-transform-refactoring
Open

Tuple transform refactoring#468
alex-kulakov wants to merge 71 commits intomasterfrom
tuple-transform-refactoring

Conversation

@alex-kulakov
Copy link
Copy Markdown
Contributor

@alex-kulakov alex-kulakov commented Apr 21, 2026

Heavy refactoring of tuple transformation and Rse.Providers made by @AlexUstinov

  • Many types from Xtensive.Tuples.Transform namespace were removed, renamed or turned into internal, whole concept simplified and now contains only what's in use
  • Xtensive.Collections.FixedList3 is removed and Xtensive.Tuples.TupleExtensions's methods that used it also removed
  • Xtensive.Orm.Rse.Providers no longer rely on virtual method to build their headers but rather use static methods within type to do so, which reduces overhead significantly by just faster calls.
  • Removed some double-checks of incoming parameters or made them a bit faster by using dotnet validators instead of ours ArgumentValidator.
  • other slight improvements here and there

@AlexUstinov
Compile for net6 with no warnings
a2a80db
@AlexUstinov
Remove not used code from tuple transform
9449267
@AlexUstinov
Get rid of ReadOnlyTransform as it is not used
e437d17
@AlexUstinov
Refactor MapTransform class
4062145
@AlexUstinov
Directly call specific Apply method to avoid params allocations
cbc605c
@AlexUstinov
Convert the TransoformedTuple abstract class to a marker interface
ea983d0
@AlexUstinov
Improve the MapTransformTuple1 code
0fd5a9d
@AlexUstinov
Improve code of the MapTransformTuple3 class
376ca61
@AlexUstinov
Improve code of the MapTransformTuple class
4beb25a
@AlexUstinov
Replace FixedList3 with internal FixedReadOnlyList3
4e268b6
@AlexUstinov
Rename TypedTransform property to TupleTransform
1a0b3a1
@AlexUstinov
Introduce better solution for readonly access to PackedFieldDescripto…
40b5c3f 
…r structure by reference
@AlexUstinov
Simplify CombineTransform implementation
5213075
@AlexUstinov
Convert TupleTransformBase to an intrface
fed8a0b
@AlexUstinov
Use composition instead of inheritance for the CombineTransform
9b0ed84
@AlexUstinov
Use composition instead of inheritance for the SegmentTransform
4107875
@AlexUstinov
Remove unused methods from the MapTransform class
4a67438
@AlexUstinov
Introduce SingleSourceMapTransform transformation
db7efb0
@AlexUstinov
Do not create map for the SegmentTransform
4eb72a0
@AlexUstinov
Improve SegmentTransform.Apply method implementation
bd7fc84
@AlexUstinov
Improve SegmentTransform constructor implementation
3280bbb
@AlexUstinov
Improve MapTransform constructor implementation
f48d39f
@AlexUstinov
Rename the CombineTransform class to the ConcatTransform
14690cb
@AlexUstinov
Do not create map for the ConcatTransform
10f9388
@AlexUstinov
Do not use MapTransform to inject primary keys to the entity tuples
3fe1b5c
@AlexUstinov
Do not use MapTransform to create seek keys in the EntitySetBase
f2a176e
@AlexUstinov
Delete the MapTransform class and its dependencies
283d37e
@AlexUstinov
Rename SingleSourceMapTransform class to MapTransform
5a0b213
@AlexUstinov
Get rid of the TransformedTuple<TTransform> base class
05a94e1
@AlexUstinov
Get rid of the redundand ITupleTransform interface
486dfd4
AlexUstinov and others added 30 commits January 26, 2022 22:06
@AlexUstinov
Simplify Provider class code
dd5f3af
@AlexUstinov
Simplify code of the ExecutableProvider class
0835f37
@AlexUstinov
Remove remaining argument checks in providers hierarchy
7840f5c
@alex-kulakov
Merge branch '7.1' into tuple-transform-refactoring
6e1d47c 
# Conflicts:
#	Directory.Build.props
#	Extensions/Xtensive.Orm.Security/Cryptography/GenericHashingService.cs
#	Extensions/Xtensive.Orm.Security/Cryptography/MD5HashingService.cs
#	Extensions/Xtensive.Orm.Security/Cryptography/SHA1HashingService.cs
#	Extensions/Xtensive.Orm.Security/Cryptography/SHA256HashingService.cs
#	Extensions/Xtensive.Orm.Security/Cryptography/SHA384HashingService.cs
#	Extensions/Xtensive.Orm.Security/Cryptography/SHA512HashingService.cs
#	Orm/Xtensive.Orm.Sqlite/Sql.Drivers.Sqlite/ProviderInitializer.cs
#	Orm/Xtensive.Orm.Tests/Storage/Randomized/RandomizedTest.cs
#	Orm/Xtensive.Orm.Tests/Upgrade/ConflictsByTable/TestBase.cs
#	Orm/Xtensive.Orm/Core/Extensions/ArrayExtensions.cs
#	Orm/Xtensive.Orm/Orm/EntitySetBase.cs
#	Orm/Xtensive.Orm/Orm/Model/TypeInfo.cs
#	Orm/Xtensive.Orm/Orm/Providers/NameBuilder.cs
#	Orm/Xtensive.Orm/Orm/Providers/SqlCompiler.Include.cs
#	Orm/Xtensive.Orm/Orm/Providers/SqlProvider.cs
#	Orm/Xtensive.Orm/Orm/QueryableExtensions.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/AggregateProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/CalculateProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/ConcatProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/ContainsTableProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/FreeTextProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/IncludeProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/OrderProviderBase.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Executable/ExecutableRawProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/ExecutableProvider.cs
#	Orm/Xtensive.Orm/Tuples/Packed/PackedFieldAccessor.cs
#	Orm/Xtensive.Orm/Tuples/Packed/PackedFieldDescriptiorExtensions.cs
#	Orm/Xtensive.Orm/Tuples/Packed/PackedFieldDescriptor.cs
#	Orm/Xtensive.Orm/Tuples/Packed/PackedTuple.cs
#	Orm/Xtensive.Orm/Tuples/Transform/TupleTransformBase.cs
#	Orm/Xtensive.Orm/Tuples/Tuple.cs
#	Orm/Xtensive.Orm/Tuples/TupleExtensions.cs
@alex-kulakov
Organizational changes of building provider headers being in region, …
18a8a60 
…not in constructor section
@alex-kulakov
Rse.Providers.Provider validates header and sources for not having nulls
c23c81e 
+ some warnings resolved
@alex-kulakov
Caching IPreCompiler wrappers for rewriters
63ebab5
@alex-kulakov
Fix merge error of wrong index of calculated column in IncludeProvide…
022c688 
…r's header
@alex-kulakov
Improved Header building for certain providers
99ff9c5
@alex-kulakov
No Enumerable.Last() calls
e7961ae
@alex-kulakov
Remove changelog file of 7.1 branch
9d9fb2f
@alex-kulakov
Merge branch '7.2' into tuple-transform-refactoring
db0a4e1 
# Conflicts:
#	Orm/Xtensive.Orm.Sqlite/Sql.Drivers.Sqlite/ProviderInitializer.cs
#	Orm/Xtensive.Orm/Orm/EntitySetBase.cs
#	Orm/Xtensive.Orm/Orm/Providers/SqlProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/AggregateProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/ApplyProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/BinaryProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/CalculateProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/ContainsTableProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/ExistenceProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/IncludeProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/LockProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/RawProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/SelectProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/StoreProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/TagProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/UnaryProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/VoidProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/ExecutableProvider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Provider.cs
#	Orm/Xtensive.Orm/Orm/Rse/Transformation/ColumnMappingInspector.cs
#	Orm/Xtensive.Orm/Tuples/Transform/CombineTransform.cs
#	Orm/Xtensive.Orm/Tuples/Transform/CutInTransform.cs
#	Orm/Xtensive.Orm/Tuples/Transform/CutOutTransform.cs
#	Orm/Xtensive.Orm/Tuples/Transform/Internals/MapTransformTuple.cs
#	Orm/Xtensive.Orm/Tuples/Transform/MapTransform.cs
#	Orm/Xtensive.Orm/Tuples/Transform/ReadOnlyTransform.cs
#	Orm/Xtensive.Orm/Tuples/Transform/TupleTransformBase.cs
#	Orm/Xtensive.Orm/Tuples/Transform/WrappingTransformTupleBase.cs
@alex-kulakov
Merge branch 'master' into tuple-transform-refactoring
6bbb6dc 
# Conflicts:
#	Orm/Xtensive.Orm.Tests.Core/Tuples/Transform/CutInTransformTest.cs
#	Orm/Xtensive.Orm.Tests.Core/Tuples/Transform/MapTransformTest.cs
#	Orm/Xtensive.Orm.Tests.Core/Tuples/Transform/MergeTransformTest.cs
#	Orm/Xtensive.Orm.Tests.Core/Tuples/Transform/ReadOnlyTransformTest.cs
#	Orm/Xtensive.Orm/Linq/ExpressionExtensions.cs
#	Orm/Xtensive.Orm/Orm/Linq/Translator.Expressions.cs
#	Version.props
@alex-kulakov
Merge branch 'master' into tuple-transform-refactoring
799812d
@alex-kulakov
Removed unused class
8cdffe7
@alex-kulakov
Revert "Caching IPreCompiler wrappers for rewriters"
3bdded4 
This reverts commit 63ebab5.
@alex-kulakov
Merge branch 'master' into tuple-transform-refactoring
4a27b18
@alex-kulakov
Add EntitySet tests to check case of complex keys
b8175f0
@alex-kulakov
No TupleDescriptor.FieldTypes array usage from outside the type
89af35b
@alex-kulakov
Add some tests for SegmentTransform and ConcatTransform
e8e9b33 
- Performance tests of constructors
- ToString test for ConcatTransform
@alex-kulakov
ConcatTransform doesn't hold original descriptors just for ToString()…
eff8897 
… opertion
@alex-kulakov
Made TupleDescriptor's fieldTypes readonly field
961f37f
@alex-kulakov
No struct checks for default for internal usage
cf82f3c 
- everywhere inside the project transformations are perforemed on valid
  descriptors so we can skip checks of structs, transformations are public though
  so we have to keep validation in public ctor
@alex-kulakov
Avoid complicated arithmetics API for basic operation
0201d46
@alex-kulakov
Use direct lengths of array instead of Count property
c4f82ad
@alex-kulakov
A bit faster parameter validation
7728009
@alex-kulakov
Additional tests of TupleDescriptor
d8d8f29
@alex-kulakov
Improve changelog
f3f1763
@alex-kulakov
Merge branch 'master' into tuple-transform-refactoring
4faebd0 
# Conflicts:
#	ChangeLog/7.2.2-dev.txt
@alex-kulakov
Merge branch 'master' into tuple-transform-refactoring
cbf53e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alex-kulakov @AlexUstinov