Skip to content

chore: migrate to yaml/go-yaml #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ccoVeille wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −4
Open

chore: migrate to yaml/go-yaml #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analysis/yaml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

"github.com/gobwas/glob"
sitter "github.com/smacker/go-tree-sitter"
"gopkg.in/yaml.v3"
"go.yaml.in/yaml/v3"
)

// To get a node back from a tree-sitter query, it *must* have a capture name.
Expand Down
2 changes: 1 addition & 1 deletion analysis/yaml_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
sitter "github.com/smacker/go-tree-sitter"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gopkg.in/yaml.v3"
"go.yaml.in/yaml/v3"
)

func TestReadFile(t *testing.T) {
Expand Down
3 changes: 2 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ require (
github.com/smacker/go-tree-sitter v0.0.0-20240827094217-dd81d9e9be82
github.com/stretchr/testify v1.10.0
github.com/urfave/cli/v3 v3.0.0-beta1
gopkg.in/yaml.v3 v3.0.1
go.yaml.in/yaml/v3 v3.0.4
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says the maintained fork is github.com/go-yaml/yaml, but this change actually migrates imports/dependency to go.yaml.in/yaml/v3. Please either update the PR description/title to match the chosen module path, or switch the dependency/imports to the module referenced in the description so the intent is unambiguous for reviewers and future maintainers.

Copilot uses AI. Check for mistakes.
)

require (
Expand All @@ -37,4 +37,5 @@ require (
golang.org/x/net v0.35.0 // indirect
golang.org/x/sys v0.30.0 // indirect
gopkg.in/warnings.v0 v0.1.2 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)
Comment on lines +40 to 41
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stated motivation is that gopkg.in/yaml.v3 is no longer maintained, but it is still present in go.mod (as an indirect dependency). Can we eliminate this by updating the transitive dependency that pulls it in, or by adding an appropriate replace (if intended) so the build no longer depends on gopkg.in/yaml.v3 at all? At minimum, it would help to confirm via go mod why -m gopkg.in/yaml.v3 and document/justify why it remains.

Suggested change
gopkg.in/yaml.v3 v3.0.1 // indirect
)
)
replace gopkg.in/yaml.v3 => go.yaml.in/yaml/v3 v3.0.4

Copilot uses AI. Check for mistakes.
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ github.com/urfave/cli/v3 v3.0.0-beta1 h1:6DTaaUarcM0wX7qj5Hcvs+5Dm3dyUTBbEwIWAjc
github.com/urfave/cli/v3 v3.0.0-beta1/go.mod h1:FnIeEMYu+ko8zP1F9Ypr3xkZMIDqW3DR92yUtY39q1Y=
github.com/xanzy/ssh-agent v0.3.3 h1:+/15pJfg/RsTxqYcX6fHqOXZwwMP+2VyYWJeWM2qQFM=
github.com/xanzy/ssh-agent v0.3.3/go.mod h1:6dzNDKs0J9rVPHPhaGCukekBHKqfl+L3KghI1Bc68Uw=
go.yaml.in/yaml/v3 v3.0.4 h1:tfq32ie2Jv2UxXFdLJdh3jXuOzWiL1fo0bu/FbuKpbc=
go.yaml.in/yaml/v3 v3.0.4/go.mod h1:DhzuOOF2ATzADvBadXxruRBLzYTpT36CKvDb3+aBEFg=
golang.org/x/crypto v0.0.0-20220622213112-05595931fe9d/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
golang.org/x/crypto v0.35.0 h1:b15kiHdrGCHrP6LvwaQ3c03kgNhhiMgvlhxHQhmg2Xs=
golang.org/x/crypto v0.35.0/go.mod h1:dy7dXNW32cAb/6/PRuTNsix8T+vJAqvuIy5Bli/x0YQ=
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"os"

"github.com/gobwas/glob"
"gopkg.in/yaml.v3"
"go.yaml.in/yaml/v3"
)

type Severity string
Expand Down
Loading