Skip to content

Fix Class::get_cell/get_class_cell lifetimes - #739

Merged
richarddd merged 1 commit into
DelSkayn:masterfrom
goffrie:class-cell-lifetime
Sep 4, 2026
Merged

Fix Class::get_cell/get_class_cell lifetimes#739
richarddd merged 1 commit into
DelSkayn:masterfrom
goffrie:class-cell-lifetime

Conversation

@goffrie

@goffrie goffrie commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description of changes

There was nothing bounding 'a so these were effectively returning &'static references.

Checklist

  • Added change to the changelog
  • Created unit tests for my feature if needed

Disclosure: this issue was discovered by an LLM review.

@richarddd richarddd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@richarddd
richarddd merged commit e54cde1 into DelSkayn:master Sep 4, 2026
35 checks passed
@goffrie
goffrie deleted the class-cell-lifetime branch September 4, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants