fix: raise ValueError for out-of-range duration strings - #1504
Merged
Merged
Conversation
parse_duration() accepted scientific-notation values that overflow datetime.timedelta and leaked OverflowError through logger.add(). Catch that and report a ValueError consistent with other duration parse failures. Fixes Delgan#1502
Owner
|
That's good, thanks. Please disclose AI usage next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_duration()accepted scientific-notation duration strings that overflowdatetime.timedeltaand leakedOverflowErrorthroughlogger.add()forrotation/retention.ValueErrorwith the same style as the other duration parse errors.1e6sare unchanged.Fixes #1502
Test plan
1e14s/1e20s/1e309sfor both rotation and retention raiseValueErrortests/test_filesink_rotation.py+tests/test_filesink_retention.py(198 passed, 3 skipped)