Repository navigation
Fix #1525: neutralise C0/C1 control characters in log messages - #1526
Open
inchang-ing wants to merge 1 commit into
Open
inchang-ing wants to merge 1 commit into
inchang-ing wants to merge 1 commit into
Conversation
Add an opt-in 'sanitize' option to logger.add() which escapes C0, DEL and C1 control characters contained in the logged message before it is written to the sink. This prevents terminal escape-sequence injection (clearing the screen, renaming the window, injecting phishing links) from untrusted message content. The default behaviour is unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1525.
Adds an opt-in
sanitizeargument tologger.add()that escapes C0, DEL and C1 control characters contained in the logged message before it is written to the sink, preventing terminal escape-sequence injection (screen clearing, window renaming, phishing links). The default behaviour is unchanged.