Loadout Optimizer: wait for vendor items before the first search#11861
Open
delphiactual wants to merge 1 commit into
Open
Loadout Optimizer: wait for vendor items before the first search#11861delphiactual wants to merge 1 commit into
delphiactual wants to merge 1 commit into
Conversation
Entering LO kicked off a search immediately, then vendor items finished loading a few seconds later, changing the inputs and restarting the whole search. Track completion of the vendor load (including the follow-up item component fetches) and hold off processing until it settles, presenting the wait as processing so the UI doesn't flash a no-results state. Vendor load failures resolve the same promise, so a failed load starts the search without vendor items rather than pausing forever. Refreshes don't re-enter the loading state; unchanged inputs are already caught by the existing input memoization. Changelog: The Loadout Optimizer now waits for vendor items to finish loading before starting its search, instead of starting a search and immediately restarting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entering LO kicked off a search immediately, then vendor items finished loading a few seconds later, changing the inputs and restarting the whole search. Track completion of the vendor load (including the follow-up item component fetches) and hold off processing until it settles, presenting the wait as processing so the UI doesn't flash a no-results state. Vendor load failures resolve the same promise, so a failed load starts the search without vendor items rather than pausing forever. Refreshes don't re-enter the loading state; unchanged inputs are already caught by the existing input memoization.