Fix CodeQL gate lookup for busy queues#820
Merged
Merged
Conversation
Signed-off-by: SS-42 <noreply@incogni.to>
Owner
|
Thank you for the sharp diagnosis and the surgical fix — the newest-5-runs window falling behind on a busy queue was exactly what took down half of today's PR fleet (and retroactively explains earlier gate flakes we'd worked around with re-trigger commits). Server-side head_sha filtering is the right call, and the enforcement predicate stays untouched. Admin-merged ahead of the queued test matrix (workflow-only change, checks were only queue-blocked) to unblock the backlog. Much appreciated! |
DeusData
added a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
DeusData
added a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
DeusData
added a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
DeusData
added a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
DeusData
added a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
DeusData
added a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
DeusData
added a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
DeusData
added a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
DeusData
added a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This was referenced Jul 3, 2026
DeusData
added a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
DeusData
added a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
DeusData
added a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
head_shafilter instead of scanning only the latest 5 runsEvidence
Several active PRs had
security / codeql-gatetime out withno run yet...while their CodeQL SAST run on the same head SHA had already completed successfully. In a busy Actions queue, the matching CodeQL run can fall out of the first 5 workflow runs before the gate sees it.Verified the replacement query returns
success completedfor the affected head SHAs from #782, #784, and #812.Verification
git diff --checkruby -e 'require "yaml"; YAML.load_file(".github/workflows/_security.yml"); puts "yaml ok"'gh api "repos/DeusData/codebase-memory-mcp/actions/workflows/codeql.yml/runs?head_sha=<sha>&per_page=1" --jq '.workflow_runs[] | "\(.conclusion) \(.status)"'for the affected SHA values