Repository navigation
Update NuGet packages; pin ImageSharp and Stripe.net - #1473
Merged
Merged
Conversation
- Bump ASP.NET Core/EF Core to 10.0.12, NSubstitute 6.2.0, xunit.runner.visualstudio 4.0.0, Microsoft.NET.Test.Sdk 18.10.1, coverlet 10.1.0, Dapper, Markdig, altcover - Pin SixLabors.ImageSharp to [2.1.13], the last Apache-2.0 release (3.0+ is Split License) - Pin Stripe.net to [52.2.0]; 53.x targets a new Stripe API version, so webhook ConstructEvent would reject events from the currently configured endpoint version - Dependabot: ignore ImageSharp >= 3.0.0 and Stripe.net major updates - Fix ambiguous NSubstitute Returns(null) call surfaced by NSubstitute 6.2 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SixLabors.ImageSharpto[2.1.13]: the last Apache-2.0 release. 3.0+ is under the Six Labors Split License.Stripe.netto[52.2.0]: 53.0.0 targets a newer Stripe API version, andEventUtility.ConstructEventrejects webhook events from other API versions. With 53, all 7 webhook endpoint tests returnedBadRequest, which would make production webhooks fail the same way as Fix Stripe webhook endpoints returning 500s to Stripe #1463. Upgrade Stripe.net only together with the webhook endpoint API version in the Stripe dashboard.Returns(null)call that NSubstitute 6.2 rejects.dotnet outdatedskips exact-range ([x.y.z]) pins, sodotnet outdated -uleaves both packages alone.Test plan
dotnet build: 0 warnings, 0 errorsdotnet test: UnitTests 154/154, Tests 104/104, FunctionalTests 3/3🤖 Generated with Claude Code