fix(sse): correct SSE-connected config polling interval from 15 hours to 15 minutes - #198
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the SSE-connected configuration “backstop” polling interval in EnvironmentConfigManager so that polling continues to run at a meaningful cadence after SSE connects (minutes rather than hours), helping ensure missed SSE messages are still eventually reconciled.
Changes:
- Correct SSE backstop polling interval from 15 hours to 15 minutes.
- Rename the interval constant to
SSE_POLL_INTERVAL_MSto match other interval constants and make units explicit. - Update SSE-start handling to use the renamed constant for logging and scheduling.
Suppressed comments (1)
src/main/java/com/devcycle/sdk/server/local/managers/EnvironmentConfigManager.java:135
- This debug log prints a bare number for the interval; adding the unit (ms) makes the message unambiguous when troubleshooting.
DevCycleLogger.debug("SSE Connected - setting polling interval to " + SSE_POLL_INTERVAL_MS);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jonathannorris
force-pushed
the
fix/sse-polling-interval
branch
from
August 6, 2026 13:43
093cb83 to
25c4380
Compare
suthar26
approved these changes
Aug 6, 2026
kaushalkapasi
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pollingIntervalSSEMSwas15 * 60 * 60 * 1000, which is 15 hours, not 15 minutes. Once SSE connects,handleSSEStartedswaps the normal polling interval for this one, so the backstop poll that catches missed SSE messages was effectively never running. js-sdks uses 10 minutes for the same backstop, go-server-sdk uses 5.Also renames it to
SSE_POLL_INTERVAL_MSto match the other interval constants and make the units explicit.Notes
handleSSEErrorstill only logs: it doesn't resetisSSEConnectedor restore the normal polling interval. Both js-sdks and go-server-sdk do restore polling on SSE failure, happy to do that as a follow-up since it's a behaviour change rather than a units fix.