Don't create archiver dropfiles for forbidden visits#361
Open
Don't create archiver dropfiles for forbidden visits#361
Conversation
Contributor
Author
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
pblowey
force-pushed
the
stop-archiving-industrial-visits
branch
from
d4a9b05 to
62c4853
Compare
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"il" and "in" visits should not be archived. The archiver service currently creates dropfiles for all visits and relies on the safeguards later in the process to stop these from being archived.
This PR adds a feature to specify forbidden visit codes in the recipe and avoids creating dropfiles if the visit starts with one of the forbidden codes.
Also adds tests for the archiver service.