Repository navigation
Cleanup close(bool) calls - #321
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncTCP was refactored such that the boolean passed to close is now unused and ignored.
Passing true was asking for an "immediate" close: this fature is ignored since 2019 (if I saw it right)
This PR replaces calls to close(true) to close()
Note: for ESP8266, I think this change also better aligns ESP8266 behavior with ESP32 behavior.
close() on esp32 is only calling tcp_recved while close(true) on esp8266 was, on top, calling tcp_close.
I propose we align the calls and drop the request for immediate close which is something anyway ignored in esp32