fix: warrior stance reminders in Aura/Buff Reminders#458
Open
nulltyto wants to merge 1 commit into
Open
Conversation
Warrior stances are shapeshift forms, not auras, so GetPlayerAuraBySpellID never detected the active stance: Fury/Prot reminders showed permanently even while in the correct stance, and Arms showed nothing because the cast spell wasn't reported by IsPlayerSpell. Detect stances through the stance bar (GetShapeshiftFormInfo) instead, which reports both whether a stance is known and whether it is active. Map each spec to its stance: Arms -> Battle Stance, Fury -> Berserker Stance, Prot -> Defensive Stance. The reminder now hides once the desired stance is active and is suppressed when the stance isn't known.
Contributor
Author
|
Not tested in PVP. Not sure if there is anything relevant here b/c I believe there is PVP fallback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Aura/Buff Reminders warrior stance behavior reported on Discord: https://discord.com/channels/585577383847788554/1518276017930637432
Reported symptoms:
Root cause
Warrior stances are shapeshift forms, not auras, so
C_UnitAuras.GetPlayerAuraBySpellID(386196/386208)never detected the active stance. The reminder therefore reported the stance as permanently "missing" (Fury/Prot). Arms showed nothing because the gate usedIsPlayerSpell/IsSpellKnownon the cast spell, which didn't report for it.Fix
Detect stances through the stance bar via
GetShapeshiftFormInfo, which reports both whether a stance is known (present in the bar) and whether it is currently active. Each spec is mapped to its stance:The reminder now hides once the desired stance is active, and is suppressed entirely when the stance isn't known.
Notes
battle_stanceadded to defaultauras.enabled;DeepMergeDefaultsfills it for existing profiles. The options toggle auto-generates from the aura list.Locales/_keys.txtregenerated (picked up a pre-existingServer Timekey).Testing
Verified in-client that each spec shows its own stance and hides it once that stance is active.