Conversation
When a tar archive exceeds max_archive_size and is split, the newly created CloudTarUploader was not receiving the staging_dir parameter. This caused it to fall back to the system default temp directory instead of the explicitly configured staging directory. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
Please open a github issue referencing this PR. You should always have an issue, even before working on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CloudUploadController._get_tar()(barman/cloud.py), when a tar archive exceedsmax_archive_sizeand needs to be split into parts, the newly createdCloudTarUploaderis missing thestaging_dirparameterstaging_dir=self.staging_dir, but the split uploader (line 442-451) does notBug details
The initial uploader creation passes
staging_dir:But the split uploader does not:
Test plan
🤖 Generated with Claude Code